Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Insert lock while reading from the installed map#987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
MatteoPologruto merged 1 commit intoarduino:mainfromMatteoPologruto:read-lock
Aug 5, 2024

Conversation

@MatteoPologruto
Copy link
Contributor

@MatteoPologrutoMatteoPologruto commentedAug 5, 2024•
edited
Loading

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among thePull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

Code enhancement

  • What is the new behavior?

Insert lock while reading from the installed map to prevent concurrent access.

  • Does this PR introduce a breaking change?

No

  • Other information:

@MatteoPologrutoMatteoPologruto added type: enhancementProposed improvement topic: codeRelated to content of the project itself labelsAug 5, 2024
@MatteoPologrutoMatteoPologruto self-assigned thisAug 5, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.85%. Comparing base(a945e56) to head(254654f).

Additional details and impacted files
@@            Coverage Diff             @@##             main     #987      +/-   ##==========================================+ Coverage   20.70%   20.85%   +0.15%==========================================  Files          42       42                Lines        2565     2570       +5     ==========================================+ Hits          531      536       +5  Misses       1949     1949                Partials       85       85
FlagCoverage Δ
unit20.85% <100.00%> (+0.15%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@MatteoPologrutoMatteoPologruto merged commitfb06ef3 intoarduino:mainAug 5, 2024
@MatteoPologrutoMatteoPologruto deleted the read-lock branchAugust 5, 2024 15:48
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@XaytonXaytonXayton approved these changes

@umbynosumbynosAwaiting requested review from umbynos

+1 more reviewer

@alessio-peruginialessio-peruginialessio-perugini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MatteoPologrutoMatteoPologruto

Labels

topic: codeRelated to content of the project itselftype: enhancementProposed improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MatteoPologruto@codecov-commenter@alessio-perugini@Xayton
[8]ページ先頭
©2009-2025 Movatter.jp