Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix agent not able to installesptool after 1.6.0#986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
umbynos merged 6 commits intomainfromfix-esptool
Aug 5, 2024
Merged

Conversation

@umbynos
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among thePull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

bug fix

  • What is the current behavior?

The agent is not able to intallesptool after 1.6.0 (more details in#980)

  • What is the new behavior?

The old behavior is restored

  • Does this PR introduce a breaking change?
  • Other information:

No

@umbynosumbynos added os: linuxSpecific to Linux operating system os: macosSpecific to macOS operating system type: imperfectionPerceived defect in any part of project labelsAug 5, 2024
@umbynosumbynos self-assigned thisAug 5, 2024
@codecov-commenter
Copy link

codecov-commenter commentedAug 5, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.01%. Comparing base(46fbb34) to head(d27b9b0).

Additional details and impacted files
@@            Coverage Diff             @@##             main     #986      +/-   ##==========================================- Coverage   20.04%   20.01%   -0.04%==========================================  Files          42       42                Lines        2569     2568       -1     ==========================================- Hits          515      514       -1  Misses       1968     1968                Partials       86       86
FlagCoverage Δ
unit20.01% <100.00%> (-0.04%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@XaytonXayton added this to the1.6.1 milestoneAug 5, 2024
@umbynosumbynos linked an issueAug 5, 2024 that may beclosed by this pull request
3 tasks
@XaytonXayton removed this from the1.6.1 milestoneAug 5, 2024
@umbynosumbynos added type: enhancementProposed improvement topic: codeRelated to content of the project itself labelsAug 5, 2024
Co-authored-by: MatteoPologruto <109663225+MatteoPologruto@users.noreply.github.com>
Copy link
Contributor

@MatteoPologrutoMatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, nice work 🚀

umbynos reacted with heart emoji
Copy link
Contributor

@XaytonXayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Local tests are OK. The problematicesptool package installation works and if it was previously broken, a new install request will fix it.

umbynos reacted with heart emoji
@umbynosumbynos merged commit6287df1 intomainAug 5, 2024
@umbynosumbynos deleted the fix-esptool branchAugust 5, 2024 14:02
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@XaytonXaytonXayton approved these changes

@MatteoPologrutoMatteoPologrutoMatteoPologruto approved these changes

Assignees

@umbynosumbynos

Labels

os: linuxSpecific to Linux operating systemos: macosSpecific to macOS operating systemtopic: codeRelated to content of the project itselftype: enhancementProposed improvementtype: imperfectionPerceived defect in any part of project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Esptool: No such file or directory" error when uploading code to ESP8266 board

4 participants

@umbynos@codecov-commenter@Xayton@MatteoPologruto
[8]ページ先頭
©2009-2025 Movatter.jp