Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Create a single universal executable for macOS#964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@MatteoPologruto
Copy link
Contributor

@MatteoPologrutoMatteoPologruto commentedJun 12, 2024•
edited
Loading

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among thePull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

Instead of relying on the Rosetta translation to distribute the Agent for arm architectures, a single universal executable is created. It runs natively on both Apple silicon and Intel-based Mac computers.

  • Does this PR introduce a breaking change?

No

  • Other information:

umbynos reacted with hooray emoji
@MatteoPologrutoMatteoPologruto added type: enhancementProposed improvement topic: infrastructureRelated to project infrastructure labelsJun 12, 2024
@MatteoPologrutoMatteoPologruto self-assigned thisJun 12, 2024
@codecov-commenter
Copy link

codecov-commenter commentedJun 12, 2024•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.04%. Comparing base (04414e2) to head (78ed8cc).
⚠️ Report is 31 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main     #964   +/-   ##=======================================  Coverage   20.04%   20.04%           =======================================  Files          42       42             Lines        2569     2569           =======================================  Hits          515      515             Misses       1968     1968             Partials       86       86
FlagCoverage Δ
unit20.04% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MatteoPologrutoMatteoPologrutoforce-pushed themacos-arm-release branch 2 times, most recently frome87f70a toe7b9e3cCompareJune 12, 2024 15:46
@per1234per1234 added the os: macosSpecific to macOS operating system labelJun 12, 2024
@MatteoPologrutoMatteoPologrutoforce-pushed themacos-arm-release branch 5 times, most recently from4c7bd8b tof5f10a1CompareJune 17, 2024 13:08
@MatteoPologrutoMatteoPologruto marked this pull request as ready for reviewJune 17, 2024 13:08
@MatteoPologrutoMatteoPologruto linked an issueJun 17, 2024 that may beclosed by this pull request
6 tasks
@umbynos
Copy link
Contributor

Have you had the chance to test the autoupdate mechanism?
Another doubt that comes to my mind is: have you tested that when using the cloud editor the tools install is performed successfully? (selecting the correct macos arm64 tool if present)?

@Xayton
Copy link
Contributor

Xayton commentedJul 9, 2024•
edited
Loading

The tests were good:

  • The auto-update mechanism works correctly. The tests found no issues (but anopportunity for improvement).
  • The tools installation was successful: the arm64 version of the executable will try to download the "closes" version, so arm64 if available, or amd64 otherwise. In both cases the download works.

@XaytonXayton self-requested a reviewJuly 9, 2024 14:16
@MatteoPologrutoMatteoPologruto merged commitda1fa2e intoarduino:mainJul 10, 2024
@MatteoPologrutoMatteoPologruto deleted the macos-arm-release branchJuly 10, 2024 08:05
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@XaytonXaytonXayton approved these changes

+1 more reviewer

@umbynosumbynosumbynos left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@MatteoPologrutoMatteoPologruto

Labels

os: macosSpecific to macOS operating systemtopic: infrastructureRelated to project infrastructuretype: enhancementProposed improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Mac arm64 release

5 participants

@MatteoPologruto@codecov-commenter@umbynos@Xayton@per1234
[8]ページ先頭
©2009-2025 Movatter.jp