Check if a signed URL is specified and use it download tools#953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

MatteoPologruto merged 5 commits intoarduino:mainfromMatteoPologruto:install-tools-code-dup

Jul 2, 2024

Merged

Check if a signed URL is specified and use it download tools#953

MatteoPologruto merged 5 commits intoarduino:mainfromMatteoPologruto:install-tools-code-dup

Jul 2, 2024

Conversation

Copy link

Contributor

MatteoPologruto commentedMay 16, 2024•
edited
Loading

Please check if the PR fulfills these requirements

The PR has no duplicates (please search among thePull Requests
before creating one)
Tests for the changes have been added (for bug fixes / features)

What kind of change does this PR introduce?

Code enhancement

What is the current behavior?

There are two ways of dowloading tools:Download andInstall. The first one downloads and installs the tools from the package index only, while it is possible to provide a signed URL and a checksum to the second one to download a tool from there.

What is the new behavior?

Download is wrapped insideDownloadFromURL to align it toInstall.

Does this PR introduce a breaking change?

MatteoPologruto added type: enhancement

Proposed improvement

topic: codeRelated to content of the project itself labels

May 16, 2024

MatteoPologruto self-assigned this

May 16, 2024

MatteoPologruto requested a review fromumbynos

May 16, 2024 07:15

Copy link

codecov-commenter commentedMay 16, 2024•
edited
Loading

Codecov Report

Attention: Patch coverage is82.05128% with7 lines in your changes are missing coverage. Please review.

Project coverage is 20.10%. Comparing base(2fa738f) to head(afe92ea).
Report is 4 commits behind head on main.

Files	Patch %	Lines
v2/pkgs/tools.go	78.57%	6 Missing⚠️
tools/download.go	90.90%	1 Missing⚠️

Additional details and impacted files

@@            Coverage Diff             @@##             main     #953      +/-   ##==========================================- Coverage   20.64%   20.10%   -0.55%==========================================  Files          42       42                Lines        2601     2537      -64     ==========================================- Hits          537      510      -27+ Misses       1967     1943      -24+ Partials       97       84      -13