Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[EDITOR-621] add port to serial output#616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
umbynos merged 3 commits intodevelfromumbynos/serial_port
Feb 11, 2021
Merged

Conversation

umbynos
Copy link
Contributor

@umbynosumbynos commentedFeb 9, 2021
edited
Loading

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among thePull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

feature

  • What is the current behavior?

Currently we only get a serial object formatted like this{"D":"output text here\r\n"}

  • What is the new behavior?

The output now includes the port generating the output:

{    "P": "dev/ttyACM0",    "D":"output text here\r\n"}
  • Does this PR introduce a breaking change?

Probably not

  • Other information:

@umbynosumbynos self-assigned thisFeb 9, 2021
@umbynos
Copy link
ContributorAuthor

umbynos commentedFeb 9, 2021
edited
Loading

@smellai please test binarieshere

@umbynosumbynos added the type: enhancementProposed improvement labelFeb 9, 2021
@umbynosumbynos requested a review fromsmellaiFebruary 9, 2021 16:48
@umbynosumbynos merged commitb3860b0 intodevelFeb 11, 2021
@umbynosumbynos deleted the umbynos/serial_port branchFebruary 11, 2021 14:55
umbynos added a commit that referenced this pull requestFeb 11, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@smellaismellaismellai approved these changes

Assignees

@umbynosumbynos

Labels
type: enhancementProposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@umbynos@smellai

[8]ページ先頭

©2009-2025 Movatter.jp