Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[WE-168] Path bugfix win#270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
facchinm merged 7 commits intodevelfrompath_bugfix_win
Nov 28, 2018
Merged

[WE-168] Path bugfix win#270

facchinm merged 7 commits intodevelfrompath_bugfix_win
Nov 28, 2018

Conversation

rsora
Copy link
Contributor

This PR contains:

  • Dependency tuning for systray package for complete cross OS support (Mac OSx in particular)
  • Windows machines zip tools download issue (added testing and fixes)
  • fixed debug console html title 😸
  • little cosmetics

@rsorarsora requested a review fromfacchinmNovember 28, 2018 11:24
@rsorarsora changed the titlePath bugfix win[WE-168] Path bugfix winNov 28, 2018
t.Errorf("%v", err)
}

srcType, err := mimeType(body)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Don't we want to test the internal function that takes care of format/mime type here?

Copy link
Member

@facchinmfacchinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Apart from the extractor test everything looks fine 😄

@facchinmfacchinm merged commiteeba2ce intodevelNov 28, 2018
@umbynosumbynos deleted the path_bugfix_win branchNovember 9, 2020 17:43
@umbynosumbynos mentioned this pull requestJan 18, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@facchinmfacchinmfacchinm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@rsora@facchinm
[8]ページ先頭
©2009-2025 Movatter.jp