Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Updater requests elevation if needed (issue 981)#1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Reginald-Gillespie wants to merge3 commits intoarduino:main
base:main
Choose a base branch
Loading
fromReginald-Gillespie:main

Conversation

Reginald-Gillespie
Copy link

@Reginald-GillespieReginald-Gillespie commentedMar 26, 2025
edited
Loading

  • The PR has no duplicates

What kind of change does this PR introduce?

  1. The Arduino Cloud Agent now attempts to rerun itself as administrator if it crashes while trying to write the-temp.exe file at boot.
  2. The ACA previously copied itself tofilename.exe-temp due to a bug in the code, I fixed this so now it copies itself tofilename-temp.exe. According to my understanding of the code, this shouldn't cause any issues, but if someone more familiar with the code base could verify that, that would be good.

What is the current behavior?

Seeissue 981.

What is the new behavior?

The Agent will automatically attempt to rerun itself.

Does this PR introduce a breaking change?

Nothing should be a breaking change, according to my knowledge.

Other information:

I do not own a mac, so this has not been tested on mac. However, I think my code is good, and my code only triggers when the agent was about to crash anyways, so it's not like I would have made anything worse if it didn't work on mac =P

I'm relatively new to OSS work with others, so I'm not sure if I was supposed to add tests, or what tests I would add. If tests should be added to this, those tests probably should be added by someone more experienced with unit tests and Go.

I tried to follow the contribution guidelines, I just ran thego fmt command on the folder I modified because it added modified icons to a lot of other files when I ran it directly. I'm not sure if the commit signoff worked or not, nor how to check if it did.

@CLAassistant
Copy link

CLAassistant commentedMar 26, 2025
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Reginald-Gillespie

This comment was marked as resolved.

Signed-off-by: Reginald Gillespie <109245101+Reginald-Gillespie@users.noreply.github.com>
@Reginald-Gillespie

This comment was marked as resolved.

Signed-off-by: Reginald Gillespie <109245101+Reginald-Gillespie@users.noreply.github.com>
@Reginald-Gillespie

This comment was marked as resolved.

@codecov-commenter
Copy link

codecov-commenter commentedMar 26, 2025
edited
Loading

Codecov Report

Attention: Patch coverage is0% with25 lines in your changes missing coverage. Please review.

Project coverage is 19.99%. Comparing base(5fcb7c4) to head(fbab5eb).
Report is 6 commits behind head on main.

Files with missing linesPatch %Lines
updater/updater.go0.00%12 Missing⚠️
updater/elevate_unix.go0.00%7 Missing⚠️
updater/updater_default.go0.00%6 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main    #1026      +/-   ##==========================================- Coverage   20.14%   19.99%   -0.15%==========================================  Files          42       43       +1       Lines        3222     3246      +24     ==========================================  Hits          649      649- Misses       2488     2512      +24  Partials       85       85
FlagCoverage Δ
unit19.99% <0.00%> (-0.15%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Reginald Gillespie <109245101+Reginald-Gillespie@users.noreply.github.com>
@Reginald-Gillespie
Copy link
Author

Reginald-Gillespie commentedMar 26, 2025
edited
Loading

Imma be honest I have no clue what coverage and all means.

@per1234per1234 linked an issueMar 26, 2025 that may beclosed by this pull request
@per1234per1234 added topic: codeRelated to content of the project itself type: imperfectionPerceived defect in any part of project labelsMar 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
1 more reviewer

@EMMANUEL2811UNITECEMMANUEL2811UNITECEMMANUEL2811UNITEC approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
topic: codeRelated to content of the project itselftype: imperfectionPerceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash on failed write when updating.
5 participants
@Reginald-Gillespie@CLAassistant@codecov-commenter@EMMANUEL2811UNITEC@per1234

[8]ページ先頭

©2009-2025 Movatter.jp