Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork155
Updater requests elevation if needed (issue 981)#1026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
CLAassistant commentedMar 26, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Reginald Gillespie <109245101+Reginald-Gillespie@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Reginald Gillespie <109245101+Reginald-Gillespie@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
codecov-commenter commentedMar 26, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #1026 +/- ##==========================================- Coverage 20.14% 19.99% -0.15%========================================== Files 42 43 +1 Lines 3222 3246 +24 ========================================== Hits 649 649- Misses 2488 2512 +24 Partials 85 85
Flags with carried forward coverage won't be shown.Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Reginald Gillespie <109245101+Reginald-Gillespie@users.noreply.github.com>
Reginald-Gillespie commentedMar 26, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Imma be honest I have no clue what coverage and all means. |
Uh oh!
There was an error while loading.Please reload this page.
What kind of change does this PR introduce?
-temp.exe
file at boot.filename.exe-temp
due to a bug in the code, I fixed this so now it copies itself tofilename-temp.exe
. According to my understanding of the code, this shouldn't cause any issues, but if someone more familiar with the code base could verify that, that would be good.What is the current behavior?
Seeissue 981.
What is the new behavior?
The Agent will automatically attempt to rerun itself.
Does this PR introduce a breaking change?
Nothing should be a breaking change, according to my knowledge.
Other information:
I do not own a mac, so this has not been tested on mac. However, I think my code is good, and my code only triggers when the agent was about to crash anyways, so it's not like I would have made anything worse if it didn't work on mac =P
I'm relatively new to OSS work with others, so I'm not sure if I was supposed to add tests, or what tests I would add. If tests should be added to this, those tests probably should be added by someone more experienced with unit tests and Go.
I tried to follow the contribution guidelines, I just ran the
go fmt
command on the folder I modified because it added modified icons to a lot of other files when I ran it directly. I'm not sure if the commit signoff worked or not, nor how to check if it did.