Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork150
feat(ws): addws
endpoint#1015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecov-commenter commentedJan 28, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #1015 +/- ##==========================================- Coverage 20.14% 19.78% -0.36%========================================== Files 42 42 Lines 3222 3280 +58 ========================================== Hits 649 649- Misses 2488 2546 +58 Partials 85 85
Flags with carried forward coverage won't be shown.Click here to find out more. ☔ View full report in Codecov by Sentry. |
Motivation
Currently, the agent seems to be usinghttps://github.com/googollee/go-socket.io which (besides being archived) implements the v1.4 ofSocket.IO client (it looks like it's compatible with 2.x as well for some reason).
Now, the current state of theJS library for communicating with the agent is pretty bad from multiple points of view (from a lack of documentation to a lack of types, to an annoying number of bugs, issues and gotchas in the current implementation).
Now, the issue is that in order to communicate with the agent we're forced to use the v2 implementation (again, because server v2 seems to be working somehow, otherwise we'd have to go v1.x - seehttps://socket.io/docs/v4/client-installation/#version-compatibility), and that means our hands are tied in various places:
Additionally, the implementation is not a real websocket server as stated by [Socket.IO themselves]https://socket.io/docs/v4/#what-socketio-is-not) and that makes it incompatible with [WebSocket API]((https://developer.mozilla.org/en-US/docs/Web/API/WebSockets_API) forcing us to stay on v2 with the aforementioned drawbacks.
Feature