Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(ws): addws endpoint#1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
dido18 wants to merge3 commits intomain
base:main
Choose a base branch
Loading
fromws-endpoint
Draft

feat(ws): addws endpoint#1015

dido18 wants to merge3 commits intomainfromws-endpoint

Conversation

dido18
Copy link
Contributor

Motivation

Currently, the agent seems to be usinghttps://github.com/googollee/go-socket.io which (besides being archived) implements the v1.4 ofSocket.IO client (it looks like it's compatible with 2.x as well for some reason).

Now, the current state of theJS library for communicating with the agent is pretty bad from multiple points of view (from a lack of documentation to a lack of types, to an annoying number of bugs, issues and gotchas in the current implementation).

Now, the issue is that in order to communicate with the agent we're forced to use the v2 implementation (again, because server v2 seems to be working somehow, otherwise we'd have to go v1.x - seehttps://socket.io/docs/v4/client-installation/#version-compatibility), and that means our hands are tied in various places:

  • What kind of change does this PR introduce?

Feature

  • What is the current behavior?
  • What is the new behavior?
  • Does this PR introduce a breaking change?
  • Other information:

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is0% with59 lines in your changes missing coverage. Please review.

Project coverage is 19.78%. Comparing base(1b94ccc) to head(3e691cd).

Files with missing linesPatch %Lines
main.go0.00%59 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main    #1015      +/-   ##==========================================- Coverage   20.14%   19.78%   -0.36%==========================================  Files          42       42                Lines        3222     3280      +58     ==========================================  Hits          649      649- Misses       2488     2546      +58  Partials       85       85
FlagCoverage Δ
unit19.78% <0.00%> (-0.36%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@per1234per1234 added type: enhancementProposed improvement topic: codeRelated to content of the project itself labelsJan 29, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: codeRelated to content of the project itselftype: enhancementProposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@dido18@codecov-commenter@per1234

[8]ページ先頭

©2009-2025 Movatter.jp