Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork158
Remove global clients#1014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
dido18 wants to merge54 commits intomainChoose a base branch fromremove-global-clients
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Changes fromall commits
Commits
Show all changes
54 commits Select commitHold shift + click to select a range
90cce2c fix
dido18c96490b feat(config): add default configuration file and update config handling
dido187b4859a fix(.gitignore): add entry to ignore config.ini file
dido18279de2a test(config): add test for writing default config.ini file and update…
dido184f3ac5a test(config): add tests for retrieving config paths from XDG_CONFIG_H…
dido18c41b815 feat(config): pass config path to main loop and update handling
dido1855ca9e5 remove global systray
dido18f07103e WIP: remove hub and sh globals
dido18ef94d97 remove global clients: use callback to avoid nesting import
dido18d2d3aa6 feat(workflow): add Go installation step to release workflow
dido18640e644 refactor: rename variable 'h' to 'hub' for clarity in main.go and upd…
dido1899f8235 docs: add comments to clarify functions and handlers in config, hub, …
dido185e2161e refactor: rename 'hub' and 'serialhub' types to 'Hub' and 'Serialhub'…
dido18910bac2 refactor: rename 'Hub' and 'Serialhub' types to 'hub' and 'serialhub'…
dido1817ed6b3 revert config changes
dido1896f0f51 refactor: update logger handling and improve config path management
dido1836af1ed remove globas tools and index
dido18f939e32 refactor: enhance logging mechanism by implementing logWriter and upd…
dido18e22281f remove log websocket
dido183bbf371 remove unused global clients comment from hub struct
dido180773f99 refactor: integrate systray into hub structure and update newHub func…
dido189c2ca54 pass tests
dido187e73b6c Merge branch 'main' into remove-global-clients
dido18fc51194 chore: add comment regarding potential removal of sysStray dependencies
dido188106c84 feat: move serial port into new file
dido184dba1a8 feat: add serialhub implementation for managing serial ports
dido187ea21c0 refactor: remove serialhub parameter from newHub function and instant…
dido18a152b02 feat: move `spErr` `spClose` `spWrite` into hub (from serialhub)
dido18fac0b10 refactor: remove newSerialHub instantiation from hub initialization i…
dido18f04d5cc move `spHandlerOpen` to hub from serialport.go
dido1847213d1 refactor: remove unused serial package import from serialport.go
dido1814ddd43 renamed h into hub
dido181f9b999 fix: add hub reference to PLogger initialization in uploadHandler
dido184585769 move `spErr, spWrite, spClose spHandlerOpen at the end for redaibility
dido18283064c refactor: clean up serialport.go and serialportlist.go for clarity
dido1814d72e8 refactor: clarify the impact of removing serialPorts.List() in writer…
dido189e13dcb move serialportlist inside hub
dido18a69c0dc refactor on callback
dido187e34071 refactor: simplify hub initialization in upload handler tests
dido18815a791 refactor: remove unused port listing in checkCmd function
dido189535905 rename into `h` and revert split of serial.go
dido180699e93 refactor: rename hub parameter in send and wsHandler functions for cl…
dido18062bca0 refactor: move spHandlerOpen function from serialport.go to hub.go fo…
dido182bcc06d remove comment
dido184da1624 refactor: remove unused serialPorts variable and instance of serialhu…
dido18effe50d remove commented-out spHandlerClose call in FindPortByName for cleane…
dido18d68fc7a fix: correct GitHub link in comment for clarity
dido18fd3b2d7 refactor: replace logWriter with ChanWriter for improved logging mech…
dido180370591 refactor: move spErr, spWrite, and spClose functions from serial.go t…
dido18a50aa86 refactor: remove logger from comment
dido1865218a6 refactor: replace OnMessage with ChanWriter for improved message hand…
dido189cbe49e fix tests
dido181598ee1 Merge remote-tracking branch 'arduino/main' into remove-global-clients
cmaglie852f4eb Reuse onRegister callback
cmaglieFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
2 changes: 1 addition & 1 deletionconfig/config.ini
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
22 changes: 12 additions & 10 deletionsconn.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
125 changes: 92 additions & 33 deletionshub.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
23 changes: 13 additions & 10 deletionsinfo.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.