Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit13515f7

Browse files
authored
fix installbuilder not able to produce complete artifacts for linux/win (#855)
The condition was wrong: we were only using the else branch.This was causing the linux installers to not contain the actual binary.We do not support running installbuilder with `linux` as a target, we support `linux-x64`
1 parent3ba51ce commit13515f7

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

‎.github/workflows/release.yml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -370,14 +370,17 @@ jobs:
370370
include:
371371
-os:ubuntu-20.04
372372
platform-name:linux
373+
installbuilder-name:linux-x64
373374
installer-extension:.run
374375
-os:windows-2019
375376
arch:386
376377
platform-name:windows
378+
installbuilder-name:windows
377379
extension:.exe
378380
installer-extension:.exe
379381
-os:windows-2019
380382
platform-name:windows
383+
installbuilder-name:windows
381384
extension:.exe
382385
installer-extension:.exe
383386

@@ -418,12 +421,7 @@ jobs:
418421

419422
# installbuilder reads the env vars with certs paths and use it to sign the installer.
420423
-name:Launch Bitrock installbuilder
421-
run:|
422-
if [[ ${{matrix.platform-name}} == "linux" ]]; then
423-
${{ env.INSTALLBUILDER_PATH }} build installer.xml ${{ matrix.platform-name }}-x64 --verbose --license /tmp/license.xml --setvars ${{ env.INSTALLER_VARS }} architecture=${{ matrix.arch }}
424-
else
425-
${{ env.INSTALLBUILDER_PATH }} build installer.xml ${{ matrix.platform-name }} --verbose --license /tmp/license.xml --setvars ${{ env.INSTALLER_VARS }} architecture=${{ matrix.arch }}
426-
fi
424+
run:${{ env.INSTALLBUILDER_PATH }} build installer.xml ${{ matrix.installbuilder-name }} --verbose --license /tmp/license.xml --setvars ${{ env.INSTALLER_VARS }} architecture=${{ matrix.arch }}
427425

428426
-name:Generate archive
429427
run:tar -czvf ArduinoCreateAgent-${GITHUB_REF##*/}-${{ matrix.platform-name }}-${{ matrix.arch }}-installer.tar.gz ArduinoCreateAgent-${GITHUB_REF##*/}-${{ matrix.platform-name }}-${{ matrix.arch }}-installer${{matrix.installer-extension}}

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp