Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork410
Remove unused "verbose" field from gRPC Debug service request message#702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Remove unused "verbose" field from gRPC Debug service request message#702
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This feature has not been implemented, so the field has no purpose.
| @@ -53,8 +53,7 @@ message DebugConfigReq { | |||
| string sketch_path = 3; | |||
| string port = 4; | |||
| string interpreter = 5; | |||
| bool verbose = 6; | |||
| string import_file = 7; | |||
| string import_file = 6; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's ok to remove a field but do not change the numeric identifier of existing fields like in:
- string import_file = 7;+ string import_file = 6;
this provides a better backward compatibility (well, at least the "verbose" value won't go into "import_file" when using an old client). I'll fixi it while rebasing#687
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the information. I was following#689 as a reference, but without really knowing what I was doing.
Please check if the PR fulfills these requirements
Removal of unused field from gRPC service request message field. This feature has not been implemented, so the field has no purpose.
The presence of a
verbosefield leads the user to believe this field can be used to control the verbosity of the debug command, whereas it actually has no effect.Debug service gRPC interface doesn't have an unused
verbosefield.This will be a breaking change for anyone using the
verbosefield. However, it's likely that few, if any, will be affected.