Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Compile extract all artifacts#687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
cmaglie merged 10 commits intoarduino:masterfromcmaglie:compile_extract_all_artifacts
May 15, 2020

Conversation

@cmaglie
Copy link
Member

@cmagliecmaglie commentedMay 6, 2020•
edited by ubidefeo
Loading

Please check if the PR fulfills these requirements

  • The PR has no duplicates
  • The PR followsour contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?
This PR implements the suggestion from@rsora ->#675 (comment)
In short:

  • the build artifacts are now saved in thesketch/build/<FQBN>/... directory without any rename
  • allsketch.ino.* files are copied (including.map,.lst,.elf,.zip etc.)

Example:

$ pwd/home/cmaglie/Arduino/Blink$ lsBlink.ino$ arduino-cli compile -b arduino:avr:unoSketch uses 968 bytes (3%) of program storage space. Maximum is 32256 bytes.Global variables use 11 bytes (0%) of dynamic memory, leaving 2037 bytes for local variables. Maximum is 2048 bytes.$ lsBlink.ino  build$ ls build/arduino.avr.uno$ ls build/arduino.avr.uno/Blink.ino.eep  Blink.ino.elf  Blink.ino.hex  Blink.ino.with_bootloader.hex$ arduino-cli compile -b arduino:samd:mkr1000Sketch uses 11204 bytes (4%) of program storage space. Maximum is 262144 bytes.Global variables use 2368 bytes of dynamic memory.$ ls build/arduino.avr.uno  arduino.samd.mkr1000$ ls build/arduino.samd.mkr1000/Blink.ino.bin  Blink.ino.elf  Blink.ino.hex  Blink.ino.map  Blink.ino.with_bootloader.hex$ arduino-cli compile -b arduino:samd:mkr1000 --output-dir anotherdirSketch uses 11204 bytes (4%) of program storage space. Maximum is 262144 bytes.Global variables use 2368 bytes of dynamic memory.$ ls anotherdir/Blink.ino.bin  Blink.ino.elf  Blink.ino.hex  Blink.ino.map  Blink.ino.with_bootloader.hex

Does this PR introduce a breaking change?
The optionscompile --output/-o andupload --input/-i have been removed and replaced bycompile --output-dir andupload --input-dir respectively.

Closes#675
Closes#655

@rsorarsora requested review fromper1234 andubidefeoMay 6, 2020 15:23
@cmagliecmaglieforce-pushed thecompile_extract_all_artifacts branch 3 times, most recently fromf9704d4 to252acf9CompareMay 7, 2020 20:57
@cmagliecmaglie marked this pull request as ready for reviewMay 8, 2020 18:42
@cmagliecmaglie requested review frommasci andrsoraMay 8, 2020 18:42
@cmagliecmaglie self-assigned thisMay 8, 2020
@cmagliecmaglie added this to the0.11.0 milestoneMay 8, 2020
Copy link
Contributor

@per1234per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks cmaglie! I tried it out with an assortment of platforms and had no problems uploading.

@ubidefeo
Copy link

tested a bunch of boards with ESP32, ESP8266, SAMD21, ATMega32u4, ATMega328, they all worked and uploaded correctly

@rsora
Copy link
Contributor

rsora commentedMay 12, 2020•
edited
Loading

This PR should solve also#641 and#476

Copy link

@ubidefeoubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I can't give feedback on code changes but the feature works and makes everything much more cleaner

@rsora
Copy link
Contributor

This PR should also solve#673

Copy link
Contributor

@rsorarsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Excellent! LGTM!
I have tested how this changes affects thedebug feature and it's all 👍 (wih a MKRZero)

@cmagliecmaglieforce-pushed thecompile_extract_all_artifacts branch fromcfe70ff to31bf766CompareMay 15, 2020 15:30
@cmagliecmaglie merged commitebc28e1 intoarduino:masterMay 15, 2020
@cmagliecmaglie deleted the compile_extract_all_artifacts branchMay 15, 2020 15:50
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this pull requestJun 29, 2020
With new arduino-cli v0.11.0, output management has changed.Seearduino/arduino-cli#687Binaries are always copied.Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this pull requestJun 29, 2020
With new arduino-cli v0.11.0, output management has changed.Seearduino/arduino-cli#687Binaries are always copied.Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this pull requestJun 30, 2020
With new arduino-cli v0.11.0, output management has changed.Seearduino/arduino-cli#687Binaries are always copied.Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this pull requestJul 2, 2020
With new arduino-cli v0.11.0, output management has changed.Seearduino/arduino-cli#687Binaries are always copied.Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@per1234per1234 added the topic: codeRelated to content of the project itself labelMar 31, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ubidefeoubidefeoubidefeo approved these changes

@per1234per1234per1234 approved these changes

@mascimasciAwaiting requested review from masci

+1 more reviewer

@rsorarsorarsora approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cmagliecmaglie

Labels

topic: codeRelated to content of the project itselftype: enhancementProposed improvement

Projects

None yet

Milestone

0.11.0

Development

Successfully merging this pull request may close these issues.

4 participants

@cmaglie@ubidefeo@rsora@per1234
[8]ページ先頭
©2009-2025 Movatter.jp