Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add smart artifact find during upload#655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
rsora wants to merge4 commits intomasterfromrsora/smart-path-upload

Conversation

rsora
Copy link
Contributor

@rsorarsora commentedApr 14, 2020
edited
Loading

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among thePull Requests before creating one)
  • The PR followsour contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?

(Originates from a fix for#641)
The CLIupload step searches also in fallback locations for artifacts to upload, in case these files are missing.

  • What is the current behavior?

The CLIupload step assumes that the artifacts generated by the compile phase are also "exported" into the sketch folder (seethe Java IDE export feature). This means that during thecompile phase, the output files generated by the specific platform compiler are placed:

  • in a temporary calculated path obtained viabuilder.GenBuildPath(sketchPath)

or

  • in the user specified --build-path path
    And then "exported" (copied) into the sketch path.

This behavior could create issues for cores that do not implement correctly the "export" variables in theplatform.txt, see for examplethis core in which you have theexport recipe file extension.hex that is misaligned withthe upload file extension.zip

Since the export feature is not fundamental in the Java IDE, 3rd party core maintainers are not forced to implement it or to implement it 100% correctly, so the CLI must take in account this aspect

  • What is the new behavior?

The upload command search process is the following:

  1. search the User specifiedimportFile
  2. search into the Sketch folder (for "exported" files)
  3. search into the user specified --build-path (if passed during acompile --upload command)
  4. search into temp compile folder (calculated usingbuilder.GenBuildPath(sketchPath))
  • Does this PR introduce a breaking change?

Not really, this change adds fallback strategies to theupload implementation that should be transparent for the user.

  • Other information:

I assumed in this PR that artifact files in fallback paths are always in this formsketch.Name+".ino"+ext and not in the exported formsketch.Name + "." + fqbnSuffix + ext


Seehow to contribute

@rsorarsora changed the titleRsora/smart path uploadAdd smart artifact find during uploadApr 14, 2020
@rsorarsora added the status: in progressWork is in progress on this labelApr 14, 2020
@rsorarsoraforce-pushed thersora/smart-path-upload branch from7f3fa8e tocfcf23fCompareApril 14, 2020 12:14
@cmagliecmaglie mentioned this pull requestMay 8, 2020
4 tasks
@cmagliecmaglie deleted the rsora/smart-path-upload branchMay 19, 2020 15:28
@per1234per1234 added conclusion: duplicateHas already been submitted topic: codeRelated to content of the project itself type: imperfectionPerceived defect in any part of project and removed status: in progressWork is in progress on this labelsJan 5, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
conclusion: duplicateHas already been submittedtopic: codeRelated to content of the project itselftype: imperfectionPerceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@rsora@per1234

[8]ページ先頭

©2009-2025 Movatter.jp