Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork410
Add smart artifact find during upload#655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
7f3fa8e
tocfcf23f
Compare4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
conclusion: duplicateHas already been submitted topic: codeRelated to content of the project itself type: imperfectionPerceived defect in any part of project
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Please check if the PR fulfills these requirements
(Originates from a fix for#641)
The CLI
upload
step searches also in fallback locations for artifacts to upload, in case these files are missing.The CLI
upload
step assumes that the artifacts generated by the compile phase are also "exported" into the sketch folder (seethe Java IDE export feature). This means that during thecompile
phase, the output files generated by the specific platform compiler are placed:builder.GenBuildPath(sketchPath)
or
--build-path
pathAnd then "exported" (copied) into the sketch path.
This behavior could create issues for cores that do not implement correctly the "export" variables in the
platform.txt
, see for examplethis core in which you have theexport recipe file extension.hex
that is misaligned withthe upload file extension.zip
Since the export feature is not fundamental in the Java IDE, 3rd party core maintainers are not forced to implement it or to implement it 100% correctly, so the CLI must take in account this aspect
The upload command search process is the following:
importFile
--build-path
(if passed during acompile --upload
command)builder.GenBuildPath(sketchPath)
)Not really, this change adds fallback strategies to the
upload
implementation that should be transparent for the user.I assumed in this PR that artifact files in fallback paths are always in this form
sketch.Name+".ino"+ext
and not in the exported formsketch.Name + "." + fqbnSuffix + ext
Seehow to contribute