NotificationsYou must be signed in to change notification settings
Fork436
Star4.7k

Force notarization process to take place configuring Gon zip output#580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

rsora merged 1 commit intomasterfromrsora/notarize-zip

Feb 12, 2020

Merged

Force notarization process to take place configuring Gon zip output#580

rsora merged 1 commit intomasterfromrsora/notarize-zip

Feb 12, 2020

Conversation

Copy link

Contributor

rsora commentedFeb 12, 2020

In order to force the notarization process to take place, we need to askgon to produce a.zip file as output.

As explained here#578 /#578 (comment) thegon.config.hcl "zip" section is not mandatory di per se', but not having an "output" section at all will not start the notarization submission process for the binary.

For our release process the generated.zip file has no use, as we repackage the signed binary thatgon replaces in-place. The.zip is functional for the notary service submission only

Thanks to@zmoog for patiently explaining the whole process to me countless times 🙇‍♂️

Force notarization process to take place configuring Gon zip output

233797f

rsora added the component/packaging label

Feb 12, 2020

rsora added this to the0.8.0 milestone

Feb 12, 2020

Copy link

Contributor

zmoog commentedFeb 12, 2020

Yeah, it looks like thealtool, that gon is orchestrating behind the scenes, require the binary to be packaged in a zip file, as described in thisCustomizing the Notarization Workflow article.

So, LGTM.