Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix regression on compile and upload with attached sketches#545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
masci merged 2 commits intomasterfrommassi/fix-attach
Jan 8, 2020
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletioncli/cli_test.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -312,7 +312,7 @@ func TestCompileCommandsIntegration(t *testing.T) {
// Build sketch without FQBN
exitCode,d=executeWithArgs("compile",sketchPath)
require.NotZero(t,exitCode)
require.Contains(t,string(d),"required flag(s)\"fqbn\" not set")
require.Contains(t,string(d),"no FQBN provided")

// Build sketch for arduino:avr:uno
exitCode,d=executeWithArgs("compile","-b","arduino:avr:uno",sketchPath)
Expand Down
2 changes: 0 additions & 2 deletionscli/compile/compile.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -78,8 +78,6 @@ func NewCommand() *cobra.Command {
command.Flags().BoolVarP(&verify,"verify","t",false,"Verify uploaded binary after the upload.")
command.Flags().StringVar(&vidPid,"vid-pid","","When specified, VID/PID specific build properties are used, if boards supports them.")

command.MarkFlagRequired("fqbn")

returncommand
}

Expand Down
1 change: 0 additions & 1 deletioncli/upload/upload.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,6 @@ func NewCommand() *cobra.Command {
uploadCommand.Flags().BoolVarP(&verify,"verify","t",false,"Verify uploaded binary after the upload.")
uploadCommand.Flags().BoolVarP(&verbose,"verbose","v",false,"Optional, turns on verbose mode.")

uploadCommand.MarkFlagRequired("fqbn")
uploadCommand.MarkFlagRequired("port")

returnuploadCommand
Expand Down
[8]ページ先頭
©2009-2025 Movatter.jp