Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork435
Fix regression on compile and upload with attached sketches#545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
rsora left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
* fix regression on board attach* fix integration tests
federicobond commentedJan 8, 2020
Hi@masci, I had opened another PR which produces a nice CLI message and handles attached sketches correctly. Let me know if you are still interested in it. |
masci commentedJan 8, 2020
@federicobond go for it, I needed a quick fix to address the regression but I'll be happy to merge a more comprehensive solution! |
In attempt to improve the error messages we merged#523 but this broke the
compileandattachcommands, complaining for missing FQBN even for sketches that have been previously attached.Side note, since we merged#536, the error messages with this PR will be ok even with#523 partially reverted.