Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Improve error message on build failure#536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
masci merged 3 commits intomasterfrommassi/527
Jan 7, 2020
Merged

Improve error message on build failure#536

masci merged 3 commits intomasterfrommassi/527
Jan 7, 2020

Conversation

@masci
Copy link
Contributor

Fixes#527

At some point, deep into thelegacy package, some function returns an error with an empty message, causing the command to fail in suspense with"Error during build: build failed:.

This is a workaround, the real fix would be going on a quest in search of the command(s) returning the empty error.

@federicobond
Copy link
Contributor

Change LGTM. The errors with missing messages can be found here:

iftextSize>maxTextSize {
logger.Println(constants.LOG_LEVEL_ERROR,constants.MSG_SIZER_TEXT_TOO_BIG)
returnerrors.New("")
}
ifmaxDataSize>0&&dataSize>maxDataSize {
logger.Println(constants.LOG_LEVEL_ERROR,constants.MSG_SIZER_DATA_TOO_BIG)
returnerrors.New("")
}

If you want, I can submit a pull request adding proper messages along the lines of "text/data section exceeds available space in board" .

@masci
Copy link
ContributorAuthor

@federicobond thanks a ton for pointing me to the error, it was faster for me to just fix it in this PR but I've used your suggestion regarding the message. I've also removed the workaroundif err.Error() == "".

federicobond reacted with thumbs up emoji

@mascimasci merged commit85a0273 intomasterJan 7, 2020
@mascimasci deleted the massi/527 branchJanuary 7, 2020 16:57
@mascimasci added this to the0.7.2 milestoneJan 8, 2020
masci pushed a commit that referenced this pull requestJan 8, 2020
* Improve error message on build failure* properly report an error message
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cmagliecmagliecmaglie approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.7.2

Development

Successfully merging this pull request may close these issues.

Incomplete error message when sketch uses too much memory

3 participants

@masci@federicobond@cmaglie
[8]ページ先頭
©2009-2025 Movatter.jp