Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork436
Stricter checks on libs/cores arguments#431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Previously
globals.ParseReferenceArgswas used to parse both core reference and library reference, but this doesn't work well because:MyLib@1.0.0is a valid library reference but not a valid core reference (because it's missing the architecture part likearduino:avr@1.0.0.This PR adds another function
global.ParseLibraryReferenceArgsthat also provides a better error messages for the reason why the parameters are rejected:invalid empty library name(ex:@2.3.4)invalid empty library version(ex:MyLib@)and for cores:
invalid empry core argumentinvalid empty core reference(ex:@1.2.3)invalid empty core version(ex:arduino:avr@)invalid empty core name(ex::avr@1.2.3)invalid empty core architecture(exarduino:@1.2.3)