Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Create a compile+upload combo command#326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
zmoog merged 4 commits intomasterfromcreate-a-compile+upload-combo-command
Aug 26, 2019

Conversation

@zmoog
Copy link
Contributor

This PR adds something similar to the IDE’s “compile on upload” feature.

Idea

The intended purpose is to simplify the workflow of the board user and offer a single-step command to compile the sketch and upload to the board.

For example:

$ arduino-cli compile --fqbn arduino:samd:nano_33_iot ~/Arduino/Blink --upload --port /dev/cu.usbmodem14101 --verify

Design & Implementation

I've tried to reuse the existing implementation of both compile and upload command composing them in the Cobra commands.

Since I'm new to both the arduino-cli project and the Go programming language any feedback will be really, really (I mean it!) welcome.

@CLAassistant
Copy link

CLAassistant commentedAug 6, 2019•
edited
Loading

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@mascimasci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Approach is neat and readable 👌, code LGTM.
We'll need to pay attention to ensure flags shared between the two commands don't go out of sync but at this stage IMO it's better a little duplication than an overly complex solution.

@mascimasci added this to the0.5.0 milestoneAug 9, 2019
@zmoogzmoog marked this pull request as ready for reviewAugust 19, 2019 10:29
Copy link
Contributor

@mastrolinuxmastrolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just added a couple of suggestions, I do like the general idea and the Go part.

@zmoog
Copy link
ContributorAuthor

We're closing this PR to ship the compile+upload combo and the suggested improvements to the integration tests will be addressed in the dedicated PR (I will link it here as soon created).

@zmoogzmoog merged commit35722fd intomasterAug 26, 2019
@zmoogzmoog deleted the create-a-compile+upload-combo-command branchAugust 26, 2019 14:10
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

2 more reviewers

@mastrolinuxmastrolinuxmastrolinux left review comments

@mascimascimasci approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@zmoog@CLAassistant@masci@mastrolinux
[8]ページ先頭
©2009-2025 Movatter.jp