Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork436
fix: build.options now have the full path to used platforms#3042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
cmaglie wants to merge1 commit intoarduino:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+1 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Previously the path to the folder containing the platforms was used,(for exmaple, `/home/cmaglie/.arduino15/packages` instead of`/home/cmaglie/.arduino15/packages/arduino/hardware/avr/1.8.6`).This kept the build.options unchanged even if a platform was updated,leading to a possible cache-reuse even if a full rebuild is required.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #3042 +/- ##==========================================- Coverage 69.37% 69.34% -0.04%========================================== Files 241 241 Lines 18591 18590 -1 ==========================================- Hits 12898 12891 -7- Misses 4496 4503 +7+ Partials 1197 1196 -1
Flags with carried forward coverage won't be shown.Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
topic: build-processRelated to the sketch build process topic: codeRelated to content of the project itself type: enhancementProposed improvement
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Seehow to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Previously, the path to the folder containing the platforms was used (for example,
/home/cmaglie/.arduino15/packagesinstead of/home/cmaglie/.arduino15/packages/arduino/hardware/avr/1.8.6). This kept thebuild.optionsfile unchanged even if a platform was updated, leading to a possible cache reuse even if a full rebuild is required.What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and istitled accordingly?
Other information