Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Added gRPC functions to manage libraries in profiles#3019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
cmaglie wants to merge4 commits intoarduino:master
base:master
Choose a base branch
Loading
fromcmaglie:grpc-profiles-functions

Conversation

cmaglie
Copy link
Member

Please check if the PR fulfills these requirements

Seehow to contribute

  • The PR has no duplicates (please search among thePull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

This is an extract of#2917 containing only the gRPC part of the PR.

What is the current behavior?

Adds only the gRPC functions for managing libraries in profiles, no user-facing changes.

What is the new behavior?

Does this PR introduce a breaking change, and istitled accordingly?

No

Other information

@cmagliecmaglie self-assigned thisOct 3, 2025
@cmagliecmaglie added type: enhancementProposed improvement topic: gRPCRelated to the gRPC interface labelsOct 3, 2025
@per1234per1234 added the topic: codeRelated to content of the project itself labelOct 4, 2025
per1234
per1234 previously requested changesOct 5, 2025
@codecovCodecov
Copy link

codecovbot commentedOct 6, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is12.50000% with315 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.47%. Comparing base (20e315c) to head (27fe68b).

Files with missing linesPatch %Lines
commands/service_profile_lib_add.go0.00%95 Missing⚠️
internal/arduino/sketch/profiles.go0.00%66 Missing and 2 partials⚠️
commands/service_profile_init.go0.00%59 Missing⚠️
commands/service_profile_lib_remove.go0.00%33 Missing⚠️
commands/service_profile_lib_list.go0.00%20 Missing⚠️
commands/service_profile_set_default.go0.00%19 Missing⚠️
commands/cmderrors/cmderrors.go0.00%10 Missing and 1 partial⚠️
commands/service_library_install.go50.00%5 Missing and 2 partials⚠️
commands/service_library_resolve_deps.go90.00%2 Missing and 1 partial⚠️
Additional details and impacted files
@@            Coverage Diff             @@##           master    #3019      +/-   ##==========================================- Coverage   68.36%   67.47%   -0.90%==========================================  Files         241      246       +5       Lines       22731    23046     +315     ==========================================+ Hits        15541    15551      +10- Misses       5992     6294     +302- Partials     1198     1201       +3
FlagCoverage Δ
unit67.47% <12.50%> (-0.90%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

As stated by@per1234:> Build profile data is already provided via the LoadSketch method, so it> seems that even a mechanism that is truly for getting profile data should> be implemented by simply expanding the SketchProfile message to contain> all the data of the build profile (actually kind of silly that it> currently only provides a subset of the profile data).arduino#3019 (comment)
@per1234per1234 dismissed theirstale reviewOctober 6, 2025 13:17

Requested change has been made. Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@per1234per1234per1234 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@cmagliecmaglie

Labels
topic: codeRelated to content of the project itselftopic: gRPCRelated to the gRPC interfacetype: enhancementProposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@cmaglie@per1234
[8]ページ先頭
©2009-2025 Movatter.jp