Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork445
Taskfile cache-dep-license will update also deb package license recap#2991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
per1234 left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The change renders this workflow step obsolete:
arduino-cli/.github/workflows/check-go-dependencies-task.yml
Lines 143 to 146 ind337589
| -name:Check debian copyright file | |
| run:| | |
| task update-deb-copyright | |
| git diff --color --exit-code |
(since an out of synccopyright file will now be caught by the "Check for outdated cache" step in the workflow)
So the unnecessary step should be removed from the workflow to avoid unnecessary clutter and maintenance burden.
debian/arduino-cli/usr/share/doc/arduino-cli/copyright should be added to thepaths filters of the "Check Go Dependencies" workflow:
arduino-cli/.github/workflows/check-go-dependencies-task.yml
Lines 11 to 30 ind337589
| push: | |
| paths: | |
| -".github/workflows/check-go-dependencies-task.ya?ml" | |
| -".licenses/**" | |
| -".licensed.json" | |
| -".licensed.ya?ml" | |
| -"Taskfile.ya?ml" | |
| -"**/.gitmodules" | |
| -"**/go.mod" | |
| -"**/go.sum" | |
| pull_request: | |
| paths: | |
| -".github/workflows/check-go-dependencies-task.ya?ml" | |
| -".licenses/**" | |
| -".licensed.json" | |
| -".licensed.ya?ml" | |
| -"Taskfile.ya?ml" | |
| -"**/.gitmodules" | |
| -"**/go.mod" | |
| -"**/go.sum" |
cmaglie commentedNov 14, 2025
Thanks@per1234 I've applied the suggestions. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #2991 +/- ##==========================================+ Coverage 68.35% 69.33% +0.97%========================================== Files 241 241 Lines 22724 18590 -4134 ==========================================- Hits 15534 12889 -2645+ Misses 5992 4504 -1488+ Partials 1198 1197 -1
Flags with carried forward coverage won't be shown.Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Please check if the PR fulfills these requirements
Seehow to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Running
task general:cache-dep-licenseswill automatically update the deb package license recap in one go.What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and istitled accordingly?
Other information