Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

refactoring: implement a proper dependency (.d) file parser#2972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
cmaglie wants to merge1 commit intoarduino:master
base:master
Choose a base branch
Loading
fromcmaglie:dep_file_parser

Conversation

cmaglie
Copy link
Member

Please check if the PR fulfills these requirements

Seehow to contribute

  • The PR has no duplicates (please search among thePull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Refactor the dep (.d) file parser to handle more cases, and refine the subroutine API.

What is the current behavior?

No changes.

What is the new behavior?

No changes.

Does this PR introduce a breaking change, and istitled accordingly?

No.

Other information

@cmagliecmaglie self-assigned thisAug 11, 2025
@cmagliecmaglie added type: enhancementProposed improvement topic: codeRelated to content of the project itself labelsAug 11, 2025
@cmagliecmaglieforce-pushed thedep_file_parser branch 2 times, most recently from04aafb3 toafc0826CompareAugust 11, 2025 16:17
@codecovCodecov
Copy link

codecovbot commentedAug 12, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is94.11765% with6 lines in your changes missing coverage. Please review.
⚠️ Pleaseupload report for BASE (master@3eecf20).Learn more about missing BASE report.

Files with missing linesPatch %Lines
internal/arduino/builder/internal/utils/utils.go73.91%4 Missing and 2 partials⚠️
Additional details and impacted files
@@            Coverage Diff            @@##             master    #2972   +/-   ##=========================================  Coverage          ?   68.31%           =========================================  Files             ?      242             Lines             ?    22743             Branches          ?        0           =========================================  Hits              ?    15538             Misses            ?     6007             Partials          ?     1198
FlagCoverage Δ
unit68.31% <94.11%> (?)

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@per1234per1234 added the topic: build-processRelated to the sketch build process labelAug 29, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees

@cmagliecmaglie

Labels
topic: build-processRelated to the sketch build processtopic: codeRelated to content of the project itselftype: enhancementProposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@cmaglie@per1234
[8]ページ先頭
©2009-2025 Movatter.jp