Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Removed race condition in CI tests#2963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
cmaglie merged 1 commit intoarduino:masterfromcmaglie:race-in-tests
Jul 31, 2025

Conversation

@cmaglie
Copy link
Member

Please check if the PR fulfills these requirements

Seehow to contribute

  • The PR has no duplicates (please search among thePull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Fix a race condition in integration tests.

What is the current behavior?

==================WARNING: DATA RACEWrite at 0x00c0000be080 by goroutine 12:  bytes.(*Buffer).Write()      /home/megabug/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.4.linux-amd64/src/bytes/buffer.go:176 +0x3a  io.(*teeReader).Read()      /home/megabug/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.4.linux-amd64/src/io/io.go:630 +0xb7  bytes.(*Buffer).ReadFrom()      /home/megabug/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.4.linux-amd64/src/bytes/buffer.go:211 +0x10e  io.copyBuffer()      /home/megabug/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.4.linux-amd64/src/io/io.go:415 +0x21d  io.Copy()      /home/megabug/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.4.linux-amd64/src/io/io.go:388 +0x278  github.com/arduino/arduino-cli/internal/integrationtest.(*ArduinoCLI).run.func2()      /home/megabug/Workspace/arduino-cli/internal/integrationtest/arduino-cli.go:395 +0x156Previous write at 0x00c0000be080 by goroutine 13:  bytes.(*Buffer).Write()      /home/megabug/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.4.linux-amd64/src/bytes/buffer.go:176 +0x3a  io.(*teeReader).Read()      /home/megabug/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.4.linux-amd64/src/io/io.go:630 +0xb7  bytes.(*Buffer).ReadFrom()      /home/megabug/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.4.linux-amd64/src/bytes/buffer.go:211 +0x10e  io.copyBuffer()      /home/megabug/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.4.linux-amd64/src/io/io.go:415 +0x21d  io.Copy()      /home/megabug/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.4.linux-amd64/src/io/io.go:388 +0x278  github.com/arduino/arduino-cli/internal/integrationtest.(*ArduinoCLI).run.func3()      /home/megabug/Workspace/arduino-cli/internal/integrationtest/arduino-cli.go:404 +0x156

What is the new behavior?

Does this PR introduce a breaking change, and istitled accordingly?

Other information

@cmagliecmaglie self-assigned thisJul 31, 2025
@cmagliecmaglie added topic: infrastructureRelated to project infrastructure type: imperfectionPerceived defect in any part of project labelsJul 31, 2025
@cmagliecmaglie requested a review froma teamJuly 31, 2025 13:35
@cmagliecmaglie merged commitc41f5df intoarduino:masterJul 31, 2025
100 checks passed
@cmagliecmaglie deleted the race-in-tests branchJuly 31, 2025 13:44
@codecov
Copy link

codecovbot commentedJul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.24%. Comparing base (ed93bf3) to head (daca09f).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@##           master    #2963      +/-   ##==========================================+ Coverage   68.21%   68.24%   +0.03%==========================================  Files         241      241                Lines       22696    22696              ==========================================+ Hits        15481    15490       +9+ Misses       6014     6008       -6+ Partials     1201     1198       -3
FlagCoverage Δ
unit68.24% <ø> (+0.03%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@alessio-peruginialessio-peruginialessio-perugini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cmagliecmaglie

Labels

topic: infrastructureRelated to project infrastructuretype: imperfectionPerceived defect in any part of project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cmaglie@alessio-perugini
[8]ページ先頭
©2009-2025 Movatter.jp