Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork445
Try harder to not recompile sketch without modifications.#2961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
cmaglie wants to merge14 commits intoarduino:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
18335b6 toaa33373Comparecodecovbot commentedJul 29, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@## master #2961 +/- ##==========================================+ Coverage 68.36% 68.46% +0.09%========================================== Files 241 242 +1 Lines 22731 22893 +162 ==========================================+ Hits 15541 15674 +133- Misses 5992 6014 +22- Partials 1198 1205 +7
Flags with carried forward coverage won't be shown.Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was linked to issuesAug 17, 2025
aa41179 to1ca362cCompare1ca362c tof32315fComparef8e6556 to2a278c5CompareDuring the library detection phase, we do not have objects files yet,the only thing that we should check is if the dependency file isup-to-date.In this commit we let GCC create a dep file during the library discoveryphase.We must ensure that the build-path folder exists otherwise the compilerwill not be able to create the dep file.
2a278c5 tofa72186Comparefa72186 to1cdbf67Compare1cdbf67 tob1a6aedCompare5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
topic: build-processRelated to the sketch build process topic: codeRelated to content of the project itself type: enhancementProposed improvement
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Seehow to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Improves the checks made to the sketch to avoid useless recompilation and preprocessing.
What is the current behavior?
The sketch source code, before being compiled, undergoes a two-phase processing:
Previously, these two operations were always performed, touching the final
sketch.cpp. This resulted insketch.cppbeing recompiled every time. Moreover, the library discovery cache could not be exploited because of thesketch.cpptimestamp change.What is the new behavior?
The merged sketch file is saved in a separate
sketch.cpp.mergedfile, and it is compared to the newly generated content. If they match, the already preprocessedsketch.cppandsketch.cpp.mergedare left untouched.This is enough for the current build system to recognize that the file is already up-to-date and skip both compilation and library discovery, which greatly improves compile times.
Does this PR introduce a breaking change, and istitled accordingly?
Unless I'm missing some convoluted case, it shouldn't.
Other information