Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

linker: allow multi-step link recipe (c.combine)#2954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
cmaglie merged 4 commits intoarduino:masterfrompillo79:pr-recipe-link
Jul 31, 2025

Conversation

@pillo79
Copy link
Contributor

This PR introduces the possibility of using multiple commands for thec.combine pattern, and infrastructure that will enable using the same logic on any build step, if so decided.

Two changes in behavior are introduced:

  • When looking for multi-step recipes (e.g. hooks) inRunRecipe(), a key that exactly matchesprefix.suffix is explicitly ignored if numbered entries are found, and only used as a fallback when no other entries are present.
    This change is consistent with current docs that require aprefix.NNN.suffix syntax for multi-step recipes. A property namedprefix.suffix is undefined behavior, and is currently included among the numbered ones.

  • Reuse theRunRecipe logic for therecipe.c.combine step to allow multi-stage linking. The above change in this context means that numbered steps have priority over the single property, but both can be specified to maintain backwards compatibility (the new numbered properties are ignored by the current IDE).

NO TESTS as I don't know where to add the test case... 😇 BUT I tried with a core that defined these rules and got the exact behavior I described here. If someone can give me pointers I can add the proper test case.

Feel free to cherry-pick and/or edit and/or shoot down at will 😅

@pillo79pillo79 changed the titlePr recipe linklinker: allow multi-step link recipe (c.combine)Jul 16, 2025
@codecov
Copy link

codecovbot commentedJul 16, 2025
edited
Loading

Codecov Report

❌ Patch coverage is91.66667% with1 line in your changes missing coverage. Please review.
✅ Project coverage is 68.26%. Comparing base (4e58200) to head (6f08895).
⚠️ Report is 2 commits behind head on master.

Files with missing linesPatch %Lines
internal/arduino/builder/builder.go0.00%0 Missing and 1 partial⚠️
Additional details and impacted files
@@            Coverage Diff             @@##           master    #2954      +/-   ##==========================================+ Coverage   68.22%   68.26%   +0.03%==========================================  Files         241      241                Lines       22696    22696              ==========================================+ Hits        15484    15493       +9+ Misses       6012     6006       -6+ Partials     1200     1197       -3
FlagCoverage Δ
unit68.26% <91.66%> (+0.03%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@per1234per1234 added type: enhancementProposed improvement topic: codeRelated to content of the project itself topic: build-processRelated to the sketch build process labelsJul 16, 2025
@cmagliecmaglie self-assigned thisJul 18, 2025
@pillo79
Copy link
ContributorAuthor

pillo79 commentedJul 30, 2025
edited
Loading

@cmaglie any update on when this will be reviewed and/or merged?

cmaglie reacted with eyes emoji

pillo79and others added4 commitsJuly 31, 2025 14:34
Recipes must follow the 'prefix.NNN.suffix' pattern, where 'NNN' is anumber. When there is also a single 'prefix.suffix' property defined,make sure to not include that in the list of recipes to run. However, ifno numbered recipes are found, use the single 'prefix.suffix' form if itexists.This allows to have both a single recipe and a set of numbered recipesin the same build properties, for backwards compatibility.Signed-off-by: Luca Burelli <l.burelli@arduino.cc>
Enable the use of recipes for the `recipe.c.combine.pattern` command.Allows for more flexibility in the build process.Signed-off-by: Luca Burelli <l.burelli@arduino.cc>
@cmagliecmaglie merged commit846216e intoarduino:masterJul 31, 2025
174 of 175 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cmagliecmagliecmaglie approved these changes

Assignees

@cmagliecmaglie

Labels

topic: build-processRelated to the sketch build processtopic: codeRelated to content of the project itselftype: enhancementProposed improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pillo79@cmaglie@per1234

[8]ページ先頭

©2009-2025 Movatter.jp