Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Some bugfix in profile parsing / Better support for platforms having tools dependencies on other platforms.#2942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
cmaglie merged 5 commits intoarduino:masterfromcmaglie:some-bugfix
Jul 3, 2025

Conversation

@cmaglie
Copy link
Member

Please check if the PR fulfills these requirements

Seehow to contribute

  • The PR has no duplicates (please search among thePull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

  1. Fix a profilesketch.yml rendering bug.
  2. Fix a bug that prevents extracting all the needed information ininstalled.json.

What is the current behavior?

  1. It will print an emptylibraries: YAML object when the profile has no libraries. This is invalid YAML.
  2. If the installed platform depends on a tool from another platform, the tool metadata is not extracted in theinstalled.json file. This would eventually make the platform unusable if the original index is removed.

What is the new behavior?

  1. Thelibraries: field is not printed if there are no libraries in the profile.
  2. Theinstalled.json now has all the necessary metadata.

Does this PR introduce a breaking change, and istitled accordingly?

No

Other information

This will help to simplify the next commits.
If a platform requires tools from another referenced platform, we mustextract the relevant data in the `installed.json` file too.
Just moving code, no semantic change.Helps to get the following commit cleaner.
@cmagliecmaglie self-assigned thisJul 3, 2025
@cmagliecmaglie added topic: codeRelated to content of the project itself type: imperfectionPerceived defect in any part of project labelsJul 3, 2025
@codecov
Copy link

codecovbot commentedJul 3, 2025
edited
Loading

Codecov Report

Attention: Patch coverage is95.06173% with4 lines in your changes missing coverage. Please review.

Project coverage is 67.89%. Comparing base(4891ded) to head(5e15ea3).
Report is 4 commits behind head on master.

Files with missing linesPatch %Lines
internal/arduino/cores/packageindex/index.go94.66%3 Missing and 1 partial⚠️
Additional details and impacted files
@@            Coverage Diff             @@##           master    #2942      +/-   ##==========================================+ Coverage   67.82%   67.89%   +0.07%==========================================  Files         238      238                Lines       22460    22489      +29     ==========================================+ Hits        15234    15270      +36+ Misses       6023     6019       -4+ Partials     1203     1200       -3
FlagCoverage Δ
unit67.89% <95.06%> (+0.07%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cmagliecmaglie merged commitbe841ff intoarduino:masterJul 3, 2025
102 checks passed
@cmagliecmaglie deleted the some-bugfix branchJuly 3, 2025 14:02
@per1234per1234 added the topic: package-managementRelated to the packaging and managing of the platform/libraries labelJul 3, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@alessio-peruginialessio-peruginialessio-perugini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cmagliecmaglie

Labels

topic: codeRelated to content of the project itselftopic: package-managementRelated to the packaging and managing of the platform/librariestype: imperfectionPerceived defect in any part of project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cmaglie@alessio-perugini@per1234

[8]ページ先頭

©2009-2025 Movatter.jp