Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

ExposeDependencies field in Library struct#2891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
alessio-perugini wants to merge1 commit intomaster
base:master
Choose a base branch
Loading
fromrpc-expose-lib-dependecies

Conversation

@alessio-perugini
Copy link
Contributor

@alessio-peruginialessio-perugini commentedApr 16, 2025•
edited
Loading

Please check if the PR fulfills these requirements

Seehow to contribute

  • The PR has no duplicates (please search among thePull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Adddependencies field in the Library struct

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and istitled accordingly?

Other information

@github-actions
Copy link
Contributor

github-actionsbot commentedApr 16, 2025•
edited
Loading

The latest Buf updates on your PR. Results from workflowCheck Protocol Buffers / check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedApr 22, 2025, 3:59 PM

@alessio-peruginialessio-peruginiforce-pushed therpc-expose-lib-dependecies branch 2 times, most recently from1e03f58 to8d3292aCompareApril 16, 2025 20:24
@alessio-peruginialessio-perugini added type: enhancementProposed improvement topic: codeRelated to content of the project itself topic: gRPCRelated to the gRPC interface labelsApr 16, 2025
@alessio-peruginialessio-perugini changed the titlelibraries: expose Dependencies fieldExposeDependencies field in Library structApr 16, 2025
@alessio-peruginialessio-perugini self-assigned thisApr 17, 2025
@codecov
Copy link

codecovbot commentedApr 22, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is87.50000% with6 lines in your changes missing coverage. Please review.

Project coverage is 67.85%. Comparing base(a6db55f) to head(86fcc6d).
Report is 1 commits behind head on master.

Files with missing linesPatch %Lines
internal/arduino/libraries/loader.go80.00%4 Missing and 2 partials⚠️
Additional details and impacted files
@@            Coverage Diff             @@##           master    #2891      +/-   ##==========================================+ Coverage   67.83%   67.85%   +0.01%==========================================  Files         238      238                Lines       22419    22455      +36     ==========================================+ Hits        15209    15236      +27- Misses       6010     6016       +6- Partials     1200     1203       +3
FlagCoverage Δ
unit67.85% <87.50%> (+0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alessio-peruginialessio-peruginiforce-pushed therpc-expose-lib-dependecies branch 3 times, most recently from5e934ce to2515d05CompareApril 22, 2025 15:23
@alessio-peruginialessio-perugini marked this pull request as ready for reviewApril 22, 2025 16:01
@alessio-peruginialessio-perugini removed their assignmentJul 30, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cmagliecmaglieAwaiting requested review from cmaglie

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

topic: codeRelated to content of the project itselftopic: gRPCRelated to the gRPC interfacetype: enhancementProposed improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@alessio-perugini
[8]ページ先頭
©2009-2025 Movatter.jp