The PR has no duplicates (please search among thePull Requests
before creating one)
The PR follows
our contributing guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
UPGRADING.md has been updated with a migration guide (for breaking changes)
configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

We correctly pass the downloader config during theBuild() of the package manager

What is the current behavior?

Currently, the downloader config is not passed when building the final package manager. This led to ignoring user network configs.

What is the new behavior?

We correctly pass the downloader configs.

Does this PR introduce a breaking change, and istitled accordingly?

Other information

alessio-perugini added2 commits

April 14, 2025 07:57

packagemanager: add test downloader config

e73267c

packagemanager: fix missing downloaderConfig passing

07bfeef

During the `Build()` we forgot to pass the pmb downloaderConfig property

alessio-perugini linked an issue

Apr 14, 2025

that may beclosed by this pull request

core install command ignoresnetwork.proxy configuration#2888

Closed

3 tasks

alessio-perugini self-assigned this

Apr 14, 2025

alessio-perugini requested a review fromcmaglie

April 14, 2025 06:03

per1234 approved these changes

Apr 14, 2025

View reviewed changes

Copy link

Contributor

per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I verified this fixes#2888. Thanks Alessio!

per1234 added topic: code

Related to content of the project itself

type: imperfection

Perceived defect in any part of project

topic: package-managementRelated to the packaging and managing of the platform/libraries labels

Apr 14, 2025

Copy link

codecovbot commentedApr 14, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.83%. Comparing base(23ed1b1) to head(07bfeef).
Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@##           master    #2889   +/-   ##=======================================  Coverage   67.83%   67.83%           =======================================  Files         238      238             Lines       22418    22419    +1     =======================================+ Hits        15208    15209    +1  Misses       6010     6010             Partials     1200     1200