The PR has no duplicates (please search among thePull Requests
before creating one)
The PR follows
our contributing guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
UPGRADING.md has been updated with a migration guide (for breaking changes)
configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

A previous "fix" allowed the installation of a library from git by specifying a branch, but introduced a regression, making it impossible to install from git by specifying a revision hash.

What is the current behavior?

A library can not be installed from git using a revision hash, see#2860 for details

What is the new behavior?

It is now allowed to install from git using a revision hash.

Does this PR introduce a breaking change, and istitled accordingly?

Other information

Fix#2860

cmaglie added2 commits

April 7, 2025 17:17

Added integration test

e7f8f88

bugfix: allow lib-install from git with revision hash

95ee7ae

cmaglie self-assigned this

Apr 7, 2025

cmaglie added topic: CLI

Related to the command line interface

phase: implementation

Work is in the implementation phase

criticality: mediumOf moderate impact labels

Apr 7, 2025

cmaglie changed the title~~fix: allow lib-install from git with revision hash~~fix: allow lib-install from git using revision hash as a reference

Apr 7, 2025

cmaglie requested a review froma team

April 7, 2025 15:26

Workaround for a bug in go-git

39aca21

Copy link

codecovbot commentedApr 7, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is36.84211% with12 lines in your changes missing coverage. Please review.

Project coverage is 67.82%. Comparing base(00a33b7) to head(39aca21).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
...rnal/arduino/libraries/librariesmanager/install.go	36.84%	6 Missing and 6 partials⚠️

Additional details and impacted files

@@            Coverage Diff             @@##           master    #2882      +/-   ##==========================================- Coverage   67.88%   67.82%   -0.06%==========================================  Files         238      238                Lines       22410    22418       +8     ==========================================- Hits        15212    15205       -7- Misses       6004     6012       +8- Partials     1194     1201       +7