Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Upgrade golang version to 1.24.1#2850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
cmaglie merged 6 commits intoarduino:masterfromcmaglie:updatego
Mar 31, 2025
Merged

Conversation

@cmaglie
Copy link
Member

Please check if the PR fulfills these requirements

Seehow to contribute

  • The PR has no duplicates (please search among thePull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

As per subject.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and istitled accordingly?

Other information

@cmagliecmaglie added type: enhancementProposed improvement topic: infrastructureRelated to project infrastructure labelsFeb 27, 2025
@cmagliecmaglie self-assigned thisFeb 27, 2025
@cmaglie
Copy link
MemberAuthor

Could not upgrade due to this:

2025-02-27T10:35:36.7331257Z Installing platform opentracker:sam@1.0.5...2025-02-27T10:35:36.7334083Z Error during install: Cannot install platform: installing platform opentracker:sam@1.0.5: extracting archive: Create file C:\Users\runneradmin\AppData\Local\Temp\cli2305421146\A\tmp\package-162356431\1.0.5\system\libsam\build_gcc\NUL: open C:\Users\runneradmin\AppData\Local\Temp\cli2305421146\A\tmp\package-162356431\1.0.5\system\libsam\build_gcc\NUL: Incorrect function.2025-02-27T10:35:36.7336277Z �[90m<<< Run completed (err = exit status 1)�[0m2025-02-27T10:35:36.7336881Z ##[endgroup]2025-02-27T10:35:36.7337272Z     core_test.go:1367: 2025-02-27T10:35:36.7338737Z         Error Trace:D:/a/arduino-cli/arduino-cli/internal/integrationtest/core/core_test.go:13672025-02-27T10:35:36.7339517Z         Error:      Received unexpected error:2025-02-27T10:35:36.7340073Z                     exit status 12025-02-27T10:35:36.7340628Z         Test:       TestCoreInstallWithWrongArchiveSize2025-02-27T10:35:38.3263830Z --- FAIL: TestCoreInstallWithWrongArchiveSize (10.14s)

There is a regression in golang 1.24.0:golang/go#71752, we need to wait for go1.24.1.

@cmagliecmaglie marked this pull request as draftFebruary 27, 2025 10:55
@codecov
Copy link

codecovbot commentedMar 12, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.86%. Comparing base(7271e0a) to head(fb291ee).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@##           master    #2850   +/-   ##=======================================  Coverage   67.86%   67.86%           =======================================  Files         238      238             Lines       22412    22412           =======================================  Hits        15209    15209             Misses       6007     6007             Partials     1196     1196
FlagCoverage Δ
unit67.86% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cmagliecmaglieforce-pushed theupdatego branch 4 times, most recently fromf5cacde to06f4c98CompareMarch 31, 2025 12:20
@cmagliecmaglie changed the titleUpgrade golang version to 1.24Upgrade golang version to 1.24.1Mar 31, 2025
@cmagliecmaglie marked this pull request as ready for reviewMarch 31, 2025 12:50
@cmagliecmaglie requested a review froma teamMarch 31, 2025 12:51
@cmagliecmaglie merged commit9495b31 intoarduino:masterMar 31, 2025
106 checks passed
@cmagliecmaglie deleted the updatego branchApril 3, 2025 10:12
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@alessio-peruginialessio-peruginialessio-perugini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cmagliecmaglie

Labels

topic: infrastructureRelated to project infrastructuretype: enhancementProposed improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cmaglie@alessio-perugini
[8]ページ先頭
©2009-2025 Movatter.jp