Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

RenamedFQBN.Packager ->FQBN.Vendor#2836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
cmaglie merged 1 commit intoarduino:masterfromcmaglie:fix_fqbn_field
Feb 13, 2025

Conversation

@cmaglie
Copy link
Member

Please check if the PR fulfills these requirements

Seehow to contribute

  • The PR has no duplicates (please search among thePull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Just an API change, before publishing a package.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and istitled accordingly?

No, because the package is not yet published.

Other information

@cmagliecmaglie self-assigned thisFeb 13, 2025
@cmagliecmaglie requested a review froma teamFebruary 13, 2025 13:26
@cmagliecmaglie added type: enhancementProposed improvement topic: codeRelated to content of the project itself labelsFeb 13, 2025
@codecov
Copy link

codecovbot commentedFeb 13, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is63.63636% with4 lines in your changes missing coverage. Please review.

Project coverage is 67.77%. Comparing base(0847849) to head(37b971c).
Report is 1 commits behind head on master.

Files with missing linesPatch %Lines
commands/service_upload.go0.00%2 Missing⚠️
internal/cli/board/list.go0.00%2 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##           master    #2836      +/-   ##==========================================- Coverage   67.81%   67.77%   -0.05%==========================================  Files         238      238                Lines       22402    22402              ==========================================- Hits        15193    15184       -9- Misses       6020     6027       +7- Partials     1189     1191       +2
FlagCoverage Δ
unit67.77% <63.63%> (-0.05%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@cmagliecmaglie merged commitfff8658 intoarduino:masterFeb 13, 2025
98 checks passed
@cmagliecmaglie deleted the fix_fqbn_field branchFebruary 13, 2025 14:13
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lucarin91lucarin91lucarin91 approved these changes

@MatteoPologrutoMatteoPologrutoMatteoPologruto approved these changes

Assignees

@cmagliecmaglie

Labels

topic: codeRelated to content of the project itselftype: enhancementProposed improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cmaglie@lucarin91@MatteoPologruto
[8]ページ先頭
©2009-2025 Movatter.jp