Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fixed library install from git-url when reference points to a git branch#2833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
cmaglie merged 3 commits intoarduino:masterfromcmaglie:fix_git_install
Feb 11, 2025

Conversation

@cmaglie
Copy link
Member

Please check if the PR fulfills these requirements

Seehow to contribute

  • The PR has no duplicates (please search among thePull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Fixes library install from git-url when reference points to a git branch.

What is the current behavior?

Using the--git-url option with a specific branch gives error

Error installing Git Library: Library install failed: reference not found

What is the new behavior?

Library installs correctly

Does this PR introduce a breaking change, and istitled accordingly?

No

Other information

Fix#2825

@cmagliecmaglie added type: enhancementProposed improvement topic: codeRelated to content of the project itself labelsFeb 7, 2025
@cmagliecmaglie self-assigned thisFeb 7, 2025
@cmagliecmaglie requested a review froma teamFebruary 7, 2025 14:11
@codecov
Copy link

codecovbot commentedFeb 7, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.76%. Comparing base(a2eebcd) to head(ef4a5f4).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@##           master    #2833      +/-   ##==========================================+ Coverage   67.74%   67.76%   +0.02%==========================================  Files         238      238                Lines       22410    22402       -8     ==========================================  Hits        15181    15181+ Misses       6034     6029       -5+ Partials     1195     1192       -3
FlagCoverage Δ
unit67.76% <100.00%> (+0.02%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@cmagliecmaglie merged commitbb88dc2 intoarduino:masterFeb 11, 2025
98 checks passed
@cmagliecmaglie deleted the fix_git_install branchFebruary 11, 2025 12:42
@per1234per1234 added type: imperfectionPerceived defect in any part of project and removed type: enhancementProposed improvement labelsMar 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dido18dido18dido18 approved these changes

@MatteoPologrutoMatteoPologrutoMatteoPologruto approved these changes

Assignees

@cmagliecmaglie

Labels

topic: codeRelated to content of the project itselftype: imperfectionPerceived defect in any part of project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error installing Git Library with specific git branch

4 participants

@cmaglie@dido18@MatteoPologruto@per1234
[8]ページ先頭
©2009-2025 Movatter.jp