Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork436
Fixed panic if malformed 3rd party url is specified#2817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
alessio-perugini left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
changes LGTM. After we rebased this onto#2819 the CI should be 🟢
e9092cc intoarduino:masterUh oh!
There was an error while loading.Please reload this page.
codecovbot commentedJan 20, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## master #2817 +/- ##==========================================+ Coverage 67.62% 67.71% +0.08%========================================== Files 238 238 Lines 22388 22388 ==========================================+ Hits 15140 15159 +19+ Misses 6050 6034 -16+ Partials 1198 1195 -3
Flags with carried forward coverage won't be shown.Click here to find out more. ☔ View full report in Codecov by Sentry. |
Please check if the PR fulfills these requirements
Seehow to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Fix the panic reported in#2786
What is the current behavior?
The
arduino-clipanics by reproducing the steps described in#2786What is the new behavior?
Does this PR introduce a breaking change, and istitled accordingly?
Other information
Fix#2786