Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixed panic if malformed 3rd party url is specified#2817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
cmaglie merged 1 commit intoarduino:masterfromcmaglie:fix_panic
Jan 20, 2025

Conversation

@cmaglie
Copy link
Member

Please check if the PR fulfills these requirements

Seehow to contribute

  • The PR has no duplicates (please search among thePull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Fix the panic reported in#2786

What is the current behavior?

Thearduino-cli panics by reproducing the steps described in#2786

What is the new behavior?

$ arduino-cli update-indexError initializing instance: Invalid additional URL: parse "foo=https://arduino.esp8266.com/stable/package_esp8266com_index.json": first path segment in URL cannot contain colonDownloading index: package_index.tar.bz2 downloaded                                                                                                                           Downloading index: foo=https://espressif.github.io/arduino-esp32/package_esp32_index.json Unable to parse URL: parse "foo=https://espressif.github.io/arduino-esp32/package_esp32_index.json": first path segment in URL cannot contain colonSome indexes could not be updated.$

Does this PR introduce a breaking change, and istitled accordingly?

Other information

Fix#2786

per1234 reacted with heart emoji
@cmagliecmaglie added topic: codeRelated to content of the project itself type: imperfectionPerceived defect in any part of project labelsJan 20, 2025
@cmagliecmaglie self-assigned thisJan 20, 2025
@cmagliecmaglie marked this pull request as draftJanuary 20, 2025 09:23
Copy link
Contributor

@alessio-peruginialessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

changes LGTM. After we rebased this onto#2819 the CI should be 🟢

@cmagliecmaglie marked this pull request as ready for reviewJanuary 20, 2025 10:38
@cmagliecmaglie merged commite9092cc intoarduino:masterJan 20, 2025
97 checks passed
@cmagliecmaglie deleted the fix_panic branchJanuary 20, 2025 10:43
@codecov
Copy link

codecovbot commentedJan 20, 2025
edited
Loading

Codecov Report

Attention: Patch coverage is77.77778% with2 lines in your changes missing coverage. Please review.

Project coverage is 67.71%. Comparing base(f47399b) to head(e8e9a31).
Report is 2 commits behind head on master.

Files with missing linesPatch %Lines
commands/instances.go77.77%2 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##           master    #2817      +/-   ##==========================================+ Coverage   67.62%   67.71%   +0.08%==========================================  Files         238      238                Lines       22388    22388              ==========================================+ Hits        15140    15159      +19+ Misses       6050     6034      -16+ Partials     1198     1195       -3
FlagCoverage Δ
unit67.71% <77.77%> (+0.08%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lucarin91lucarin91Awaiting requested review from lucarin91

@dido18dido18Awaiting requested review from dido18

@MatteoPologrutoMatteoPologrutoAwaiting requested review from MatteoPologruto

1 more reviewer

@alessio-peruginialessio-peruginialessio-perugini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cmagliecmaglie

Labels

topic: codeRelated to content of the project itselftype: imperfectionPerceived defect in any part of project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Panic on invalidboard_manager.additional_urls config value

2 participants

@cmaglie@alessio-perugini

[8]ページ先頭

©2009-2025 Movatter.jp