Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Increase priority of manually-installed platform.#2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
cmaglie wants to merge11 commits intoarduino:master
base:master
Choose a base branch
Loading
fromcmaglie:installed_platform_priority

Conversation

cmaglie
Copy link
Member

Please check if the PR fulfills these requirements

Seehow to contribute

  • The PR has no duplicates (please search among thePull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Makes the manually-installed platform always preferred over the platforms installed through Board Manager

What is the current behavior?

TODO

What is the new behavior?

TODO

Does this PR introduce a breaking change, and istitled accordingly?

Other information

Draft PR to run the test-suite

@cmagliecmaglieforce-pushed theinstalled_platform_priority branch from237d69b toc8b0fc7CompareJanuary 13, 2025 15:38
@cmagliecmaglie self-assigned thisJan 13, 2025
@cmagliecmaglie added type: enhancementProposed improvement topic: codeRelated to content of the project itself labelsJan 13, 2025
@cmagliecmaglieforce-pushed theinstalled_platform_priority branch 2 times, most recently fromc3dedb2 to4de49d3CompareJanuary 16, 2025 14:04
@cmagliecmaglieforce-pushed theinstalled_platform_priority branch 3 times, most recently fromd248b1e toeb5fe21CompareFebruary 4, 2025 08:23
@cmagliecmaglieforce-pushed theinstalled_platform_priority branch fromeb5fe21 to69136e9CompareFebruary 4, 2025 08:59
@cmagliecmaglieforce-pushed theinstalled_platform_priority branch from69136e9 todad5063CompareFebruary 4, 2025 09:58
@codecovCodecov
Copy link

codecovbot commentedFeb 4, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is89.11565% with16 lines in your changes missing coverage. Please review.

Project coverage is 67.80%. Comparing base(5f84ecb) to head(dad5063).
Report is 50 commits behind head on master.

Files with missing linesPatch %Lines
internal/arduino/cores/packagemanager/loader.go86.07%5 Missing and 6 partials⚠️
internal/cli/core/list.go50.00%2 Missing and 1 partial⚠️
.../arduino/cores/packagemanager/install_uninstall.go50.00%0 Missing and 1 partial⚠️
...al/arduino/cores/packagemanager/package_manager.go95.65%1 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##           master    #2810      +/-   ##==========================================+ Coverage   67.74%   67.80%   +0.06%==========================================  Files         238      238                Lines       22410    22416       +6     ==========================================+ Hits        15181    15200      +19+ Misses       6034     6024      -10+ Partials     1195     1192       -3
FlagCoverage Δ
unit67.80% <89.11%> (+0.06%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees

@cmagliecmaglie

Labels
topic: codeRelated to content of the project itselftype: enhancementProposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@cmaglie
[8]ページ先頭
©2009-2025 Movatter.jp