The PR has no duplicates (please search among thePull Requests
before creating one)
The PR follows
our contributing guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
UPGRADING.md has been updated with a migration guide (for breaking changes)
configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Fix the error output during sketch preprocessing wrongly redirected to stdout instead of stderr.

What is the current behavior?

$ arduino-cli compile -b arduino:avr:uno /home/megabug/Arduino/Blink/Blink.ino:1:2: error: #error eeee #error eeee  ^~~~~$ arduino-cli compile -b arduino:avr:uno 1> /dev/null Error during build: exit status 1

What is the new behavior?

$ arduino-cli compile -b arduino:avr:uno /home/megabug/Arduino/Blink/Blink.ino:1:2: error: #error eeee #error eeee  ^~~~~$ arduino-cli compile -b arduino:avr:uno 1> /dev/null /home/megabug/Arduino/Blink/Blink.ino:1:2: error: #error eeee #error eeee  ^~~~~Error during build: exit status 1

Does this PR introduce a breaking change, and istitled accordingly?

Other information

Slightly refactored integration test

e22ff66

cmaglie self-assigned this

Jan 9, 2025

cmaglie added type: imperfection

Perceived defect in any part of project

topic: build-processRelated to the sketch build process labels

Jan 9, 2025

cmaglie added2 commits

January 9, 2025 15:12

Added integration test

fa37144

Fixed output channel for stderr in sketch preprocessing

5810d62

cmaglie force-pushed thecompiler-stderr branch from5ee2d75 to5810d62Compare

January 9, 2025 14:12

cmaglie changed the title~~fix: Sketch preprocessing errors were output on stdout instead of stderr~~fix: Sketch preprocessing errors were displayed on stdout instead of stderr

Jan 9, 2025

Copy link

codecovbot commentedJan 9, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.61%. Comparing base(d1b47cf) to head(5810d62).
Report is 10 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@##           master    #2806      +/-   ##==========================================- Coverage   67.63%   67.61%   -0.02%==========================================  Files         238      238                Lines       22392    22392              ==========================================- Hits        15144    15141       -3- Misses       6060     6062       +2- Partials     1188     1189       +1