Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

AddedBoardIdentify gRPC call.#2794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
cmaglie merged 9 commits intoarduino:masterfromcmaglie:board-identify-grpc
Jan 13, 2025

Conversation

@cmaglie
Copy link
Member

Please check if the PR fulfills these requirements

Seehow to contribute

  • The PR has no duplicates (please search among thePull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Adds theBoardIdentify gRPC call, this function performs the board identification based on the given "upload port properties".

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and istitled accordingly?

Other information

@cmagliecmaglie added type: enhancementProposed improvement topic: gRPCRelated to the gRPC interface labelsDec 23, 2024
@cmagliecmaglie self-assigned thisDec 23, 2024
@codecov
Copy link

codecovbot commentedDec 23, 2024•
edited
Loading

Codecov Report

Attention: Patch coverage is67.27273% with54 lines in your changes missing coverage. Please review.

Project coverage is 67.68%. Comparing base(82f37f2) to head(85cbc63).
Report is 7 commits behind head on master.

Files with missing linesPatch %Lines
commands/service_board_identify.go67.40%31 Missing and 13 partials⚠️
commands/service_board_list.go66.66%6 Missing and 4 partials⚠️
Additional details and impacted files
@@            Coverage Diff             @@##           master    #2794      +/-   ##==========================================+ Coverage   67.61%   67.68%   +0.06%==========================================  Files         238      239       +1       Lines       22392    22396       +4     ==========================================+ Hits        15141    15159      +18+ Misses       6062     6045      -17- Partials     1189     1192       +3
FlagCoverage Δ
unit67.68% <67.27%> (+0.06%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@cmagliecmaglie merged commited88bd8 intoarduino:masterJan 13, 2025
101 checks passed
@cmagliecmaglie deleted the board-identify-grpc branchJanuary 13, 2025 14:54
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@alessio-peruginialessio-peruginialessio-perugini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cmagliecmaglie

Labels

topic: gRPCRelated to the gRPC interfacetype: enhancementProposed improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cmaglie@alessio-perugini
[8]ページ先頭
©2009-2025 Movatter.jp