Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

compile: fix export when artifacts contains a folder#2788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
alessio-perugini merged 2 commits intomasterfromfix-export-artifacts-subdir
Dec 20, 2024

Conversation

@alessio-perugini
Copy link
Contributor

@alessio-peruginialessio-perugini commentedDec 17, 2024•
edited by cmaglie
Loading

Please check if the PR fulfills these requirements

Seehow to contribute

  • The PR has no duplicates (please search among thePull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Fixes the export-dir, when it tries to copy a folder it crashes.

What is the current behavior?

The copy mechanism fails to copy the dir because it's treated as a file, and the compile exits with error code 1

What is the new behavior?

We filter out the directories and copy only exported binaries files.

Does this PR introduce a breaking change, and istitled accordingly?

Other information

@alessio-peruginialessio-perugini self-assigned thisDec 17, 2024
@alessio-peruginialessio-perugini added topic: codeRelated to content of the project itself type: imperfectionPerceived defect in any part of project labelsDec 17, 2024
@alessio-peruginialessio-perugini changed the titlecompile: fix export artifact when contins foldercompile: fix export artifact when contains a folderDec 17, 2024
@codecov
Copy link

codecovbot commentedDec 17, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.58%. Comparing base(84fc413) to head(05f1851).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@##           master    #2788      +/-   ##==========================================+ Coverage   67.57%   67.58%   +0.01%==========================================  Files         238      238                Lines       22362    22363       +1     ==========================================+ Hits        15111    15115       +4+ Misses       6062     6060       -2+ Partials     1189     1188       -1
FlagCoverage Δ
unit67.58% <100.00%> (+0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@alessio-peruginialessio-peruginiforce-pushed thefix-export-artifacts-subdir branch 2 times, most recently from1944f02 to8ebca9fCompareDecember 17, 2024 15:53
@alessio-peruginialessio-perugini marked this pull request as ready for reviewDecember 17, 2024 15:57
@cmagliecmaglie changed the titlecompile: fix export artifact when contains a foldercompile: fix export when artifacts contains a folderDec 20, 2024
@alessio-peruginialessio-perugini merged commit0a116e7 intomasterDec 20, 2024
196 checks passed
@alessio-peruginialessio-perugini deleted the fix-export-artifacts-subdir branchDecember 20, 2024 10:28
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cmagliecmagliecmaglie approved these changes

@MatteoPologrutoMatteoPologrutoAwaiting requested review from MatteoPologruto

Labels

topic: codeRelated to content of the project itselftype: imperfectionPerceived defect in any part of project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alessio-perugini@cmaglie
[8]ページ先頭
©2009-2025 Movatter.jp