Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(fqbn): implement json and sql interface#2785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
lucarin91 wants to merge4 commits intoarduino:master
base:master
Choose a base branch
Loading
fromlucarin91:add-json-sql-on-fqbn

Conversation

lucarin91
Copy link

Please check if the PR fulfills these requirements

Seehow to contribute

  • The PR has no duplicates (please search among thePull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and istitled accordingly?

Other information

@CLAassistant
Copy link

CLAassistant commentedDec 16, 2024
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign ourContributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let usrecheck it.

@codecovCodecov
Copy link

codecovbot commentedDec 16, 2024
edited
Loading

Codecov Report

Attention: Patch coverage is0% with27 lines in your changes missing coverage. Please review.

Project coverage is 67.69%. Comparing base(fff8658) to head(f65c41c).

Files with missing linesPatch %Lines
pkg/fqbn/sql.go0.00%14 Missing⚠️
pkg/fqbn/json.go0.00%13 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##           master    #2785      +/-   ##==========================================- Coverage   67.76%   67.69%   -0.07%==========================================  Files         238      240       +2       Lines       22402    22429      +27     ==========================================+ Hits        15181    15184       +3- Misses       6029     6054      +25+ Partials     1192     1191       -1
FlagCoverage Δ
unit67.69% <0.00%> (-0.07%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@per1234per1234 added type: enhancementProposed improvement topic: codeRelated to content of the project itself labelsDec 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@cmagliecmagliecmaglie approved these changes

Assignees
No one assigned
Labels
topic: codeRelated to content of the project itselftype: enhancementProposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@lucarin91@CLAassistant@cmaglie@per1234

[8]ページ先頭

©2009-2025 Movatter.jp