Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

settings: addnetwork.connection_timeout andnetwork.cloud_api.skip_board_detection_calls#2770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@alessio-perugini
Copy link
Contributor

@alessio-peruginialessio-perugini commentedNov 28, 2024•
edited by cmaglie
Loading

Please check if the PR fulfills these requirements

Seehow to contribute

  • The PR has no duplicates (please search among thePull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Introduces:

  • theconnection_timeout setting, which our HTTP client will use as a timeout duration
  • thecloud_api.skip_board_detection_calls boolean setting that (iftrue) will skip the API call required to identify the board (if no installed platforms match the board).

What is the current behavior?

The current behavior uses the default timeout which is 0. It means that it will wait indefinitely.

What is the new behavior?

The new behavior will respect user settings for the connection timeout. The default will be the same, but in case the user provides thenetwork.connection_timeout: 5 it means that the HTTP client will exit with an error if the connection is taking longer than 5 seconds.
There is also a new configuration value to disable querying the Cloud API to identify a board.

Does this PR introduce a breaking change, and istitled accordingly?

Other information

per1234 reacted with thumbs up emoji
@alessio-peruginialessio-perugini linked an issueNov 28, 2024 that may beclosed by this pull request
3 tasks
@alessio-peruginialessio-perugini self-assigned thisNov 28, 2024
@codecov
Copy link

codecovbot commentedNov 28, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.55%. Comparing base(6dbff9f) to head(ff3735f).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@##           master    #2770      +/-   ##==========================================+ Coverage   67.52%   67.55%   +0.02%==========================================  Files         237      237                Lines       22362    22373      +11     ==========================================+ Hits        15101    15115      +14+ Misses       6068     6066       -2+ Partials     1193     1192       -1
FlagCoverage Δ
unit67.55% <100.00%> (+0.02%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@alessio-peruginialessio-peruginiforce-pushed the2769-skip-or-time-out-network-requests-during-board-list branch from4b44476 to665d54dCompareNovember 28, 2024 16:15
@alessio-peruginialessio-peruginiforce-pushed the2769-skip-or-time-out-network-requests-during-board-list branch from665d54d to2278bbcCompareNovember 28, 2024 16:15
@alessio-peruginialessio-perugini added type: enhancementProposed improvement topic: codeRelated to content of the project itself labelsNov 28, 2024
@alessio-peruginialessio-perugini marked this pull request as ready for reviewNovember 28, 2024 16:21
@github-actions
Copy link
Contributor

github-actionsbot commentedDec 10, 2024•
edited
Loading

The latest Buf updates on your PR. Results from workflowCheck Protocol Buffers / check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedDec 11, 2024, 11:14 AM

@cmagliecmaglieforce-pushed the2769-skip-or-time-out-network-requests-during-board-list branch from2d4aee1 to6df6b17CompareDecember 10, 2024 17:23
@cmagliecmaglieforce-pushed the2769-skip-or-time-out-network-requests-during-board-list branch from6df6b17 toab8c357CompareDecember 10, 2024 17:28
@cmagliecmaglieforce-pushed the2769-skip-or-time-out-network-requests-during-board-list branch from6d1db1e toff3735fCompareDecember 11, 2024 11:13
@cmagliecmaglie changed the titlesettings: addconnection_timeoutsettings: addnetwork.connection_timeout andnetwork.cloud_api.skip_board_detection_callsDec 18, 2024
@cmagliecmaglie merged commit5968346 intomasterDec 18, 2024
201 checks passed
@cmagliecmaglie deleted the 2769-skip-or-time-out-network-requests-during-board-list branchDecember 18, 2024 14:38
@cmagliecmaglie added this to theArduino CLI v1.1.2 milestoneDec 18, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@MatteoPologrutoMatteoPologrutoMatteoPologruto approved these changes

@cmagliecmaglieAwaiting requested review from cmaglie

Labels

topic: codeRelated to content of the project itselftype: enhancementProposed improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip or time out network requests duringboard list

3 participants

@alessio-perugini@MatteoPologruto@cmaglie
[8]ページ先頭
©2009-2025 Movatter.jp