The PR has no duplicates (please search among thePull Requests
before creating one)
The PR follows
our contributing guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
UPGRADING.md has been updated with a migration guide (for breaking changes)
configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

It makes theversion package internal.

What is the current behavior?

The packageversion is publicly importable.

What is the new behavior?

The packageversion is private.

Does this PR introduce a breaking change, and istitled accordingly?

Strictly speaking, yes. By the way, this is a purely theoretical breaking change because theversion package is useless outside the Arduino CLI, and there is no point in exporting it. I'll consider this patch more of a bug fix than a breaking change.

Other information

Made 'version' package internal

865216e

cmaglie self-assigned this

Nov 27, 2024

cmaglie added topic: code

Related to content of the project itself

type: enhancementProposed improvement labels

Nov 27, 2024

cmaglie requested review fromMatteoPologruto,alessio-perugini andumbynos

November 27, 2024 14:51

Copy link

codecovbot commentedNov 27, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.52%. Comparing base(a9597d6) to head(865216e).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@##           master    #2767      +/-   ##==========================================- Coverage   67.54%   67.52%   -0.02%==========================================  Files         237      237                Lines       22362    22362              ==========================================- Hits        15104    15101       -3- Misses       6066     6068       +2- Partials     1192     1193       +1