Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fixed protoc.zip release artifact missinggoogle/rpc/status.proto#2761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
cmaglie merged 2 commits intoarduino:masterfromcmaglie:proto_artifact
Nov 21, 2024

Conversation

@cmaglie
Copy link
Member

Please check if the PR fulfills these requirements

Seehow to contribute

  • The PR has no duplicates (please search among thePull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

It uses thebuf export function to produce the protoc.zip artifact content.buf will automatically include all the dependencies.

What is the current behavior?

The export was missing thegoogle/rpc/status.proto

What is the new behavior?

Future exports will have the missinggoogle/rpc/status.proto file again.

Does this PR introduce a breaking change, and istitled accordingly?

Other information

Fix#2755

@cmagliecmaglie self-assigned thisNov 21, 2024
@cmagliecmaglie added topic: infrastructureRelated to project infrastructure type: imperfectionPerceived defect in any part of project labelsNov 21, 2024
@codecov
Copy link

codecovbot commentedNov 21, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.53%. Comparing base(67eb95a) to head(8e1e689).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@##           master    #2761      +/-   ##==========================================- Coverage   67.55%   67.53%   -0.03%==========================================  Files         237      237                Lines       22358    22358              ==========================================- Hits        15105    15100       -5- Misses       6063     6066       +3- Partials     1190     1192       +2
FlagCoverage Δ
unit67.53% <ø> (-0.03%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚨 Try these New Features:

@cmagliecmaglie merged commitc3d05d6 intoarduino:masterNov 21, 2024
106 checks passed
@cmagliecmaglie deleted the proto_artifact branchNovember 21, 2024 14:22
@cmagliecmaglie added this to theArduino CLI v1.1.1 milestoneNov 22, 2024
giacomocusinato added a commit to arduino/arduino-ide that referenced this pull requestNov 22, 2024
…_{version}_proto.zip`- Use the CLI release proto.zip to get proto files for production versions of CLI- Extract the proto files from repo if CLI version is declared as `commitsh` or version is 1.1.0Seearduino/arduino-cli#2761
giacomocusinato added a commit to arduino/arduino-ide that referenced this pull requestNov 22, 2024
…_{version}_proto.zip`- Use the CLI release proto.zip to get proto files for production versions of CLI- Extract the proto files from repo if CLI version is declared as `commitsh` or version is 1.1.0Seearduino/arduino-cli#2761
giacomocusinato added a commit to arduino/arduino-ide that referenced this pull requestNov 27, 2024
…_{version}_proto.zip`- Use the CLI release proto.zip to get proto files for production versions of CLI- Extract the proto files from repo if CLI version is declared as `commitsh` or version is 1.1.0Seearduino/arduino-cli#2761
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@MatteoPologrutoMatteoPologrutoAwaiting requested review from MatteoPologruto

2 more reviewers

@alessio-peruginialessio-peruginialessio-perugini approved these changes

@umbynosumbynosumbynos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cmagliecmaglie

Labels

topic: infrastructureRelated to project infrastructuretype: imperfectionPerceived defect in any part of project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The proto zip release asset does not contain thegoogle/rpc/status.proto file for v1.1.0

3 participants

@cmaglie@alessio-perugini@umbynos
[8]ページ先頭
©2009-2025 Movatter.jp