Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork408
Allow use of a dependency helper source file during library detection#2758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecovbot commentedNov 18, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## master #2758 +/- ##==========================================- Coverage 67.55% 67.49% -0.07%========================================== Files 237 237 Lines 22358 22375 +17 ==========================================- Hits 15105 15101 -4- Misses 6063 6076 +13- Partials 1190 1198 +8
Flags with carried forward coverage won't be shown.Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Uh oh!
There was an error while loading.Please reload this page.
Please check if the PR fulfills these requirements
Seehow to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
This is a tentative implementation for a strategy to increase the speed of the library discovery phase.
The idea behind this PR is to add a helper file in a library, called
arduino_deps.cpp
(orarduino_deps.c
), whose only purpose is to#include
the required dependencies. If the Arduino CLI finds the helper the library detection process is performed only on that file, skipping all the other source files (that may be a lot...).Advantages:
dependencies
field in thelibrary.properties
that may become outdated if the author is not precise).Disadvantages:
arduino_deps.cpp
.arduino_deps.cpp
may be tricky.arduino_deps.cpp
may result in difficult-to-diagnose "missing include X.h" errors (that could be a workaround by including X.h in the user sketch)What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and istitled accordingly?
Other information
This may be combined with#2625 for even better performance gain