Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Avoidsignature expired error on index update, if the clock time is not set correctly.#2744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@cmaglie
Copy link
Member

@cmagliecmaglie commentedNov 7, 2024
edited
Loading

Please check if the PR fulfills these requirements

Seehow to contribute

  • The PR has no duplicates (please search among thePull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Some users reported spurious "expired signature" errors. After some investigation, we found that all of them had the wrong system date set on their machine, with a date set in the past. Even if the error says that the signature is "expired", it's a signature that is not yet valid (it will be in the future).
Since we cannot trust the system clock, we recheck the signature with a future date so we may avoid displaying a difficult-to-understand error to the user.

This PR will suppress the, apparently unrelated,signature expired error in such cases.

What is the current behavior?

An index update will trigger asignature expired error if the clock is set to a past date.

What is the new behavior?

If the clock is set to a past date, an index update will no longer trigger asignature expired error.

Does this PR introduce a breaking change, and istitled accordingly?

No

Other information

@cmagliecmaglie self-assigned thisNov 7, 2024
@cmagliecmaglie added this to theArduino CLI v1.1.1 milestoneNov 7, 2024
@cmagliecmaglie added type: enhancementProposed improvement topic: codeRelated to content of the project itself labelsNov 7, 2024
@codecov
Copy link

codecovbot commentedNov 7, 2024
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.57%. Comparing base(49c154a) to head(8a17891).

Additional details and impacted files
@@            Coverage Diff             @@##           master    #2744      +/-   ##==========================================- Coverage   67.65%   67.57%   -0.09%==========================================  Files         237      237                Lines       22356    22367      +11     ==========================================- Hits        15126    15114      -12- Misses       6036     6063      +27+ Partials     1194     1190       -4
FlagCoverage Δ
unit67.57% <100.00%> (-0.09%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@cmaglie
Copy link
MemberAuthor

Superseded by#2750

@cmagliecmaglie closed thisNov 8, 2024
@cmagliecmaglie deleted the gpg_signature_in_the_future branchNovember 8, 2024 17:27
@cmagliecmaglie removed this from theArduino CLI v1.1.1 milestoneNov 8, 2024
@per1234per1234 added the conclusion: duplicateHas already been submitted labelNov 9, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@umbynosumbynosAwaiting requested review from umbynos

@alessio-peruginialessio-peruginiAwaiting requested review from alessio-perugini

@MatteoPologrutoMatteoPologrutoAwaiting requested review from MatteoPologruto

Assignees

@cmagliecmaglie

Labels

conclusion: duplicateHas already been submittedtopic: codeRelated to content of the project itselftype: enhancementProposed improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cmaglie@per1234

[8]ページ先頭

©2009-2025 Movatter.jp