Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork445
Avoidsignature expired error on index update, if the clock time is not set correctly.#2744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecovbot commentedNov 7, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #2744 +/- ##==========================================- Coverage 67.65% 67.57% -0.09%========================================== Files 237 237 Lines 22356 22367 +11 ==========================================- Hits 15126 15114 -12- Misses 6036 6063 +27+ Partials 1194 1190 -4
Flags with carried forward coverage won't be shown.Click here to find out more. ☔ View full report in Codecov by Sentry. |
cmaglie commentedNov 8, 2024
Superseded by#2750 |
Uh oh!
There was an error while loading.Please reload this page.
Please check if the PR fulfills these requirements
Seehow to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Some users reported spurious "expired signature" errors. After some investigation, we found that all of them had the wrong system date set on their machine, with a date set in the past. Even if the error says that the signature is "expired", it's a signature that is not yet valid (it will be in the future).
Since we cannot trust the system clock, we recheck the signature with a future date so we may avoid displaying a difficult-to-understand error to the user.
This PR will suppress the, apparently unrelated,
signature expirederror in such cases.What is the current behavior?
An index update will trigger a
signature expirederror if the clock is set to a past date.What is the new behavior?
If the clock is set to a past date, an index update will no longer trigger a
signature expirederror.Does this PR introduce a breaking change, and istitled accordingly?
No
Other information