Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add possibility to embed custom libraries into the sketch#2514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
cmaglie wants to merge5 commits intoarduino:master
base:master
Choose a base branch
Loading
fromcmaglie:custrom_lib_sketch

Conversation

cmaglie
Copy link
Member

@cmagliecmaglie commentedJan 25, 2024
edited
Loading

Please check if the PR fulfills these requirements

Seehow to contribute

  • The PR has no duplicates (please search among thePull Requests before creating one)
  • The PR followsour contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Adds the possibility to include libraries in the sketchlibraries folder

What is the current behavior?

~/Arduino/Blink$ tree.├── Blink.ino└── libraries    └── ExampleLibrary        └── MyLib.h3 directories, 2 files~/Arduino/Blink$ cat Blink.ino #include <MyLib.h>void setup() {libFunction();}void loop() {}~/Arduino/Blink$ cat libraries/ExampleLibrary/MyLib.h void libFunction() {}~/Arduino/Blink$ arduino-cli compile -b arduino:avr:uno /home/cmaglie/Arduino/Blink/Blink.ino:1:10: fatal error: MyLib.h: No such file or directory #include <MyLib.h>          ^~~~~~~~~compilation terminated.Used platform Version Patharduino:avr   1.8.6   /home/cmaglie/.arduino15/packages/arduino/hardware/avr/1.8.6Error during build: exit status 1

What is the new behavior?

~/Arduino/Blink$ arduino-cli compile -b arduino:avr:uno Sketch uses 444 bytes (1%) of program storage space. Maximum is 32256 bytes.Global variables use 9 bytes (0%) of dynamic memory, leaving 2039 bytes for local variables. Maximum is 2048 bytes.Used library   Version PathExampleLibrary         /home/cmaglie/Arduino/Blink/libraries/ExampleLibraryUsed platform Version Patharduino:avr   1.8.6   /home/cmaglie/.arduino15/packages/arduino/hardware/avr/1.8.6

Does this PR introduce a breaking change, and istitled accordingly?

Other information

Resolves#1255

matthijskooijman and per1234 reacted with hooray emojimanchoz reacted with heart emoji
@cmagliecmaglie self-assigned thisJan 25, 2024
@cmagliecmaglie added type: enhancementProposed improvement topic: codeRelated to content of the project itself topic: CLIRelated to the command line interface labelsJan 25, 2024
@codecovCodecov
Copy link

codecovbot commentedJan 25, 2024
edited
Loading

Codecov Report

Attention: Patch coverage is81.81818% with8 lines in your changes missing coverage. Please review.

Project coverage is 67.56%. Comparing base(54209cf) to head(83a9b40).
Report is 81 commits behind head on master.

Files with missing linesPatch %Lines
internal/arduino/sketch/sketch.go71.42%4 Missing and 2 partials⚠️
internal/arduino/libraries/libraries_location.go77.77%2 Missing⚠️
Additional details and impacted files
@@           Coverage Diff           @@##           master    #2514   +/-   ##=======================================  Coverage   67.55%   67.56%           =======================================  Files         237      237             Lines       22358    22398   +40     =======================================+ Hits        15105    15134   +29- Misses       6063     6071    +8- Partials     1190     1193    +3
FlagCoverage Δ
unit67.56% <81.81%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@XaytonXayton changed the titleAdd possibility to embed libraries into the sketchAdd possibility to embed custom libraries into the sketchFeb 19, 2024
@XaytonXayton linked an issueNov 25, 2024 that may beclosed by this pull request
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees

@cmagliecmaglie

Labels
topic: CLIRelated to the command line interfacetopic: codeRelated to content of the project itselftype: enhancementProposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support bundling libraries with a sketch
1 participant
@cmaglie

[8]ページ先頭

©2009-2025 Movatter.jp