Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[skip-changelog] Improve the definition of FQBN and explicitly state which characters are allowed#2509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@MatteoPologruto
Copy link
Contributor

@MatteoPologrutoMatteoPologruto commentedJan 18, 2024•
edited
Loading

Please check if the PR fulfills these requirements

Seehow to contribute

  • The PR has no duplicates (please search among thePull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Documentation enhancement

What is the new behavior?

Each field of thefqbn is checked to verify if it contains invalid characters.

Does this PR introduce a breaking change, and istitled accordingly?

No

Other information

dankeboy36 reacted with heart emoji
@MatteoPologrutoMatteoPologruto added type: enhancementProposed improvement topic: documentationRelated to documentation for the project labelsJan 18, 2024
@MatteoPologrutoMatteoPologruto self-assigned thisJan 18, 2024
@MatteoPologrutoMatteoPologruto linked an issueJan 18, 2024 that may beclosed by this pull request
3 tasks
@MatteoPologrutoMatteoPologruto marked this pull request as ready for reviewJanuary 18, 2024 16:52
@umbynosumbynos requested a review fromper1234January 18, 2024 17:11
Copy link
Contributor

@alessio-peruginialessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I remember that talking with@cmaglie we wanted to enforce this check in the codebase.
Let's wait for his response if we want to tackle that in the same PR.

@cmaglie
Copy link
Member

I remember that talking with@cmaglie we wanted to enforce this check in the codebase. Let's wait for his response if we want to tackle that in the same PR.

Yep, it would be nice to start enforcing it.
I don't know how much platforms would break, BTW it seems very unlikely (in case we may relax the specification to include some extra char later).

@codecov
Copy link

codecovbot commentedJan 29, 2024•
edited
Loading

Codecov Report

Attention:6 lines in your changes are missing coverage. Please review.

Comparison is base(51119b2) 68.92% compared to head(b469a22) 68.91%.
Report is 1 commits behind head on master.

❗ Current headb469a22 differs from pull request most recent head0f4bcf2. Consider uploading reports for the commit0f4bcf2 to get more accurate results

FilesPatch %Lines
internal/arduino/cores/fqbn.go50.00%4 Missing and 2 partials⚠️
Additional details and impacted files
@@            Coverage Diff             @@##           master    #2509      +/-   ##==========================================- Coverage   68.92%   68.91%   -0.02%==========================================  Files         204      204                Lines       20452    20464      +12     ==========================================+ Hits        14096    14102       +6- Misses       5207     5211       +4- Partials     1149     1151       +2
FlagCoverage Δ
unit68.91% <50.00%> (-0.02%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@MatteoPologrutoMatteoPologruto merged commit66a9d6d intoarduino:masterFeb 6, 2024
@MatteoPologrutoMatteoPologruto deleted the fqbn-formal-definition branchFebruary 6, 2024 08:33
@dankeboy36
Copy link
Contributor

dankeboy36 commentedFeb 10, 2024•
edited
Loading

Thanks for the feature. I seearduin-o:av-r:un-o:a=b=c=d is valid. What config option and value does it imply? Can you confirm that config optiona has a value of"b=c=d"?

Update: I see yes

"properties.Map{\n\"cpu\":\"atmega\",\n\"speed\":\"1000\",\n\"extra\":\"core=arduino\",\n}",

dankeboy36 added a commit to dankeboy36/fqbn that referenced this pull requestFeb 10, 2024
Upstream:arduino/arduino-cli#2460Upstream:arduino/arduino-cli#2509Closes:#8Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
dankeboy36 added a commit to dankeboy36/fqbn that referenced this pull requestFeb 10, 2024
Upstream:arduino/arduino-cli#2460Upstream:arduino/arduino-cli#2509Closes:#8Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
dankeboy36 pushed a commit to dankeboy36/fqbn that referenced this pull requestFeb 10, 2024
## [1.0.4](1.0.3...1.0.4) (2024-02-10)### Bug Fixes* align implementation with most recent specs ([#9](#9)) ([c62036f](c62036f)), closes [arduino/arduino-cli#2460](arduino/arduino-cli#2460) [arduino/arduino-cli#2509](arduino/arduino-cli#2509) [#8](#8)
@MatteoPologruto
Copy link
ContributorAuthor

Hello@dankeboy36! Yes, I am confirming thatarduin-o:av-r:un-o:a=b=c=d is a valid FQBN and the config keya has the value ofb=c=d.

dankeboy36 reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cmagliecmagliecmaglie approved these changes

@umbynosumbynosAwaiting requested review from umbynos

@per1234per1234Awaiting requested review from per1234

+1 more reviewer

@alessio-peruginialessio-peruginialessio-perugini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MatteoPologrutoMatteoPologruto

Labels

topic: documentationRelated to documentation for the projecttype: enhancementProposed improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provide a formal definition of what characters are allowed in the FQBN

4 participants

@MatteoPologruto@cmaglie@dankeboy36@alessio-perugini
[8]ページ先頭
©2009-2025 Movatter.jp