Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Added a compatibility trick indebug -I fortoolchain.prefix key#2428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@cmaglie
Copy link
Member

Please check if the PR fulfills these requirements

Seehow to contribute

  • The PR has no duplicates (please search among thePull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Thedebug.toolchain.prefix key was ignored in older versions of the Arduino IDE.

In the upcoming release (Arduino IDE 2.2.2) instead the key is used, but in the older releases of the platforms it was wrongly set to"arm-none-eabi-" when we actually want"arm-none-eabi".

This patch ensures backward and forward compatibility.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and istitled accordingly?

Other information

The key was ignored in older versions of the Arduino IDE.In the upcoming release (Arduino IDE 2.2.2) the key is used, but it waswrongly set to "arm-none-eabi-" when we actually want "arm-none-eabi".This patch ensure backward and forward compatibility.
@cmagliecmaglie self-assigned thisNov 15, 2023
@cmagliecmaglie added type: enhancementProposed improvement topic: CLIRelated to the command line interface labelsNov 15, 2023
@cmagliecmaglie added this to theArduino CLI v0.35.0 milestoneNov 15, 2023
@codecov
Copy link

codecovbot commentedNov 15, 2023

Codecov Report

Attention:1 lines in your changes are missing coverage. Please review.

Comparison is base(6c86fa2) 67.27% compared to head(9e0443b) 67.33%.
Report is 2 commits behind head on master.

FilesPatch %Lines
arduino/builder/internal/detector/detector.go0.00%0 Missing and 1 partial⚠️
Additional details and impacted files
@@            Coverage Diff             @@##           master    #2428      +/-   ##==========================================+ Coverage   67.27%   67.33%   +0.05%==========================================  Files         210      210                Lines       20523    20526       +3     ==========================================+ Hits        13807    13821      +14+ Misses       5578     5566      -12- Partials     1138     1139       +1
FlagCoverage Δ
unit67.33% <85.71%> (+0.05%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@cmagliecmaglie merged commite071333 intoarduino:masterNov 15, 2023
@cmagliecmaglie deleted the debug-backward-compatibibilty branchNovember 15, 2023 16:42
cmaglie added a commit that referenced this pull requestNov 15, 2023
…hain.prefix` key (#2428)* Added a compatibility trick in "debug -I" for toolchain.prefix keyThe key was ignored in older versions of the Arduino IDE.In the upcoming release (Arduino IDE 2.2.2) the key is used, but it waswrongly set to "arm-none-eabi-" when we actually want "arm-none-eabi".This patch ensure backward and forward compatibility.* Fixed debug command
umbynos added a commit to arduino/ArduinoCore-mbed that referenced this pull requestNov 15, 2023
With newer versions of the IDE this was causing problems.Seearduino/arduino-cli#2428
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@umbynosumbynosAwaiting requested review from umbynos

@ubidefeoubidefeoAwaiting requested review from ubidefeo

@MatteoPologrutoMatteoPologrutoAwaiting requested review from MatteoPologruto

1 more reviewer

@alessio-peruginialessio-peruginialessio-perugini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cmagliecmaglie

Labels

topic: CLIRelated to the command line interfacetype: enhancementProposed improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@cmaglie@alessio-perugini
[8]ページ先頭
©2009-2025 Movatter.jp