Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork436
Fix 1200-bps touch DTR handling (Windows)#2234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The reason why it was originally introduced:arduino/Arduino@a6909bdWhy we are removing it now?* Windows does preserve the state of the RTS/DTR bits on successive opening of the serial port.* The serial library used in the Arduino IDE 1.8.x has a bug when trying to set DTR=false, on successive opening of the port the DTR line is set back high by the USB serial driver. This works differently from the serial library we use in the Arduino CLI, that sets DTR=false for good and this change is preserved on the successive opening of the port.* Having the serial port left in a state with DTR=false may cause problems to tools uploading later.It may probably completely removed, but for now, to reduce the testingsurface, it will be disabled only for Windows.
umbynos approved these changesJun 30, 2023
4 tasks
MemberAuthor
cmaglie commentedJun 30, 2023
Failing checks are OK ✅. They are happening because this PR is against an old release branch. |
4 tasks
kittaakos pushed a commit to arduino/arduino-ide that referenced this pull requestJun 30, 2023
Ref:arduino/arduino-cli#2234Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
4 tasks
kittaakos pushed a commit to arduino/arduino-ide that referenced this pull requestJun 30, 2023
Ref:arduino/arduino-cli#2234Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit to arduino/arduino-ide that referenced this pull requestJun 30, 2023
Ref:arduino/arduino-cli#2234Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
cmaglie added a commit that referenced this pull requestJun 30, 2023
The reason why it was originally introduced:arduino/Arduino@a6909bdWhy we are removing it now?* Windows does preserve the state of the RTS/DTR bits on successive opening of the serial port.* The serial library used in the Arduino IDE 1.8.x has a bug when trying to set DTR=false, on successive opening of the port the DTR line is set back high by the USB serial driver. This works differently from the serial library we use in the Arduino CLI, that sets DTR=false for good and this change is preserved on the successive opening of the port.* Having the serial port left in a state with DTR=false may cause problems to tools uploading later.It may probably completely removed, but for now, to reduce the testingsurface, it will be disabled only for Windows.
cmaglie added a commit that referenced this pull requestJun 30, 2023
The reason why it was originally introduced:arduino/Arduino@a6909bdWhy we are removing it now?* Windows does preserve the state of the RTS/DTR bits on successive opening of the serial port.* The serial library used in the Arduino IDE 1.8.x has a bug when trying to set DTR=false, on successive opening of the port the DTR line is set back high by the USB serial driver. This works differently from the serial library we use in the Arduino CLI, that sets DTR=false for good and this change is preserved on the successive opening of the port.* Having the serial port left in a state with DTR=false may cause problems to tools uploading later.It may probably completely removed, but for now, to reduce the testingsurface, it will be disabled only for Windows.
fabik111 pushed a commit to fabik111/arduino-cli that referenced this pull requestAug 29, 2025
The reason why it was originally introduced:arduino/Arduino@a6909bdWhy we are removing it now?* Windows does preserve the state of the RTS/DTR bits on successive opening of the serial port.* The serial library used in the Arduino IDE 1.8.x has a bug when trying to set DTR=false, on successive opening of the port the DTR line is set back high by the USB serial driver. This works differently from the serial library we use in the Arduino CLI, that sets DTR=false for good and this change is preserved on the successive opening of the port.* Having the serial port left in a state with DTR=false may cause problems to tools uploading later.It may probably completely removed, but for now, to reduce the testingsurface, it will be disabled only for Windows.
cmaglie added a commit that referenced this pull requestSep 1, 2025
The reason why it was originally introduced:arduino/Arduino@a6909bdWhy we are removing it now?* Windows does preserve the state of the RTS/DTR bits on successive opening of the serial port.* The serial library used in the Arduino IDE 1.8.x has a bug when trying to set DTR=false, on successive opening of the port the DTR line is set back high by the USB serial driver. This works differently from the serial library we use in the Arduino CLI, that sets DTR=false for good and this change is preserved on the successive opening of the port.* Having the serial port left in a state with DTR=false may cause problems to tools uploading later.It may probably completely removed, but for now, to reduce the testingsurface, it will be disabled only for Windows.Co-authored-by: Cristian Maglie <c.maglie@arduino.cc>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
criticality: highestOf highest impact os: windowsSpecific to Windows operating system priority: highResolution is a high priority topic: codeRelated to content of the project itself type: imperfectionPerceived defect in any part of project
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Please check if the PR fulfills these requirements
Seehow to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
This PR disables the step that sets DTR low on the 1200-bps touch subroutine.
This is the reason why it was originally introduced:arduino/Arduino@a6909bd
Why we are removing it now?
It may probably be applied to all OS but, for now, it will be disabled only for Windows to reduce the testing surface.
What is the current behavior?
Upload may fail on some boards (arduino/ArduinoCore-renesas#10).
What is the new behavior?
Uploads should be successful...
Does this PR introduce a breaking change, and istitled accordingly?
No, in theory. A lot of testing is required to be sure.
Other information