Commite2bc059

Massimiliano Pippi

authored

Fix regression on compile and upload with attached sketches (#545)

* fix regression on board attach* fix integration tests

1 parent85a0273 commite2bc059Copy full SHA for e2bc059

File tree

-4

lines changed

-4

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -312,7 +312,7 @@ func TestCompileCommandsIntegration(t *testing.T) {`
`312`	`312`	`// Build sketch without FQBN`
`313`	`313`	`exitCode,d=executeWithArgs("compile",sketchPath)`
`314`	`314`	`require.NotZero(t,exitCode)`
`315`		`-require.Contains(t,string(d),"required flag(s)\"fqbn\" not set")`
	`315`	`+require.Contains(t,string(d),"no FQBN provided")`
`316`	`316`
`317`	`317`	`// Build sketch for arduino:avr:uno`
`318`	`318`	`exitCode,d=executeWithArgs("compile","-b","arduino:avr:uno",sketchPath)`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -78,8 +78,6 @@ func NewCommand() *cobra.Command {`
`78`	`78`	`command.Flags().BoolVarP(&verify,"verify","t",false,"Verify uploaded binary after the upload.")`
`79`	`79`	`command.Flags().StringVar(&vidPid,"vid-pid","","When specified, VID/PID specific build properties are used, if boards supports them.")`
`80`	`80`
`81`		`-command.MarkFlagRequired("fqbn")`
`82`		`-`
`83`	`81`	`returncommand`
`84`	`82`	`}`
`85`	`83`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,6 @@ func NewCommand() *cobra.Command {`
`54`	`54`	`uploadCommand.Flags().BoolVarP(&verify,"verify","t",false,"Verify uploaded binary after the upload.")`
`55`	`55`	`uploadCommand.Flags().BoolVarP(&verbose,"verbose","v",false,"Optional, turns on verbose mode.")`
`56`	`56`
`57`		`-uploadCommand.MarkFlagRequired("fqbn")`
`58`	`57`	`uploadCommand.MarkFlagRequired("port")`
`59`	`58`
`60`	`59`	`returnuploadCommand`

Comments

(0)