Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Adding support for sketch-specific build properties#29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
stevemarple wants to merge1 commit intoarduino:master
base:master
Choose a base branch
Loading
fromstevemarple:dev-global-macros

Conversation

@stevemarple
Copy link

Tests for existence of a build_props.txt file in the sketch
directory. If present reads properties similar to those found in the
hardware and board files, allowing the user to easily customise the
build for a specific sketch. Most useful when containing lines similar
to

compiler.c.extra_flags=-D NDEBUGcompiler.cpp.extra_flags=-D NDEBUG -D MYLIBRARY_BUFSIZE=100

which enables the user to have macros defined for all compilation
units, including libraries.

Signed-off-by: Steve Marplestevemarple@googlemail.com

luelista and HankLloydRight reacted with thumbs up emoji
Tests for existence of a build_props.txt file in the sketchdirectory. If present reads properties similar to those found in thehardware and board files, allowing the user to easily customise thebuild for a specific sketch. Most useful when containing lines similarto    compiler.c.extra_flags=-D NDEBUG    compiler.cpp.extra_flags=-D NDEBUG -D MYLIBRARY_BUFSIZE=100which enables the user to have macros defined for all compilationunits, including libraries.Signed-off-by: Steve Marple <stevemarple@googlemail.com>
@stevemarple
Copy link
Author

One point of consideration: adding sketch-specific build properties allows the user to overridebuild.path (which is removed when all compilation units must be rebuilt), commands such ascompiler.cmd and paths such ascompiler.path. Sketches and theirbuild_props.txt file taken from untrusted sources could therefore be considered harmful. This could be mitigated by requiring a user-preference to be set before sketch-specific build properties are enabled. Alternatively the properties could be limited to a subset (eg by excluding*.path,*.cmd, andrecipe.*).

@stevemarple
Copy link
Author

Addresses#15

@ffissore
Copy link
Contributor

Assigning to@cmaglie: he will explain why such external defines are considered harmful

@ffissore
Copy link
Contributor

btw, nice code, thank you very much

@FrankBoesing
Copy link

ping..
nothing happened.. are you going to merge this, or not ?

@luelista
Copy link

Hey,@arduino,@ffissore,@cmaglie
... I think this pull request implements a very useful and missing feature - what do you think about merging it?

@ffissore
Copy link
Contributor

@max-weller sorry you missed the news. I no longer work for arduinohttps://groups.google.com/a/arduino.cc/forum/#!msg/developers/YJLX6AZHem4/kpsLef7XBAAJ

@ricardojlrufino
Copy link

+1

@CLAassistant
Copy link

CLAassistant commentedApr 9, 2021•
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

@cmagliecmaglie

Labels

status: on holdDo not proceed at this time

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@stevemarple@ffissore@FrankBoesing@luelista@ricardojlrufino@CLAassistant@cmaglie@per1234@facchinm@rsora
[8]ページ先頭
©2009-2025 Movatter.jp